Refs #35985 - Implement optional Katello integration #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
foreman-integration
branch
from
831919c to
4619840
Compare
ehelms
reviewed
Jan 24, 2023
| Boolean $katello = false, | ||
| ) { | ||
| if $katello { | ||
| include certs::puppet |
There was a problem hiding this comment.
I assume we'll have this as a soft dependency where we assume it's presence if someone is setting katello true that they will have the requisite dependencies present? I am fine with that, and it helps make things easier, I am wanting to ensure we call that out (maybe in the Readme?).
There was a problem hiding this comment.
Calling it out in the readme is a good thin. Will do.
Katello uses a different certificate structure. This moves over the integration bits from puppet-foreman_proxy_content to this module. It also means fewer variables need to be set in the installer itself.
ekohl
force-pushed
the
foreman-integration
branch
from
4619840 to
a81f0e5
Compare
ehelms
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #801 reopened. The whole effort to build PSF ended up going nowhere for various reasons. This revives the previous effort to it it more user friendly. We can remove the need to pass various parameters for end users, which makes life easier.
Additional PRs will be needed to make use of this.