-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add interactivity to openSeadragonGL #6
base: master
Are you sure you want to change the base?
Conversation
f120224
to
2954386
Compare
75bec9b
to
a130705
Compare
a130705
to
f0d96c0
Compare
f0d96c0
to
19a70c5
Compare
19a70c5
to
c406aca
Compare
I tried this but found the GLSL updates were not being rendered. To fix it, I changed
In the gamma change handler in my top-level script that calls OpenSeadragonGL, I set the gamma to a new value and then add a call to
Now changing the gamma updates the display instantly, which is lovely. As a further improvement, it would be good to flag when the input parameters to GLSL change, so that the tile-drawing callback only invokes GLSL when required. |
We now copy the rendered canvas before any application of shaders. Then, all shaders take the original rendered canvas as input for every subsequent update to the tiles. This allows interactive updating of parameters passed to the shaders.
Additionally, the world is updating on init of openSeadragonGL. Previously, one could only observe the effect of the shaders if the openseadragon world happened to update after the init of openSeadragonGL due to interaction or loading of tiles.