Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freelancer and CTT support #25

Closed
wants to merge 40 commits into from
Closed

Freelancer and CTT support #25

wants to merge 40 commits into from

Conversation

AnthonyFuller
Copy link
Contributor

@AnthonyFuller AnthonyFuller commented Nov 15, 2022

This adds support for Freelancer (Evergreen) and for people connecting with the Closed Technical Test.

To-do:

  • Mission End screens
  • Mastery
  • Think about how we're going to deal with allunlockables (EG differs from retail)

Possibly anything else that differs.

@LennardF1989
Copy link
Member

I would propose a squash of all changes to a single commit before merging.

@RDIL
Copy link
Member

RDIL commented Nov 15, 2022

@LennardF1989 we’ll squash it when merging.

@grappigegovert
Copy link
Member

I don't think the unlockables are going to be a problem. Most of the stuff that's added are EG only things that won't show up in non-eg anyways. I think the only things that affect non-eg are the new TOKEN_OUTFIT_REWARD_HERO_LEGACY47_SUIT, which afaik should work fine in 3.130, and TOKEN_OUTFIT_HERO_ANCESTRAL_SUIT/TOKEN_OUTFIT_HERO_LUXURIOUS_SUIT, which changed to the 'evergreen' subtype. (I'm assuming) that subtype doesn't exist in 3.130 and will show as some broken locr, but nothing gamebreaking. The other changes are just OrderIndex, which isn't important.

@RDIL RDIL self-requested a review November 15, 2022 16:48
@AnthonyFuller
Copy link
Contributor Author

Most of the stuff that's added are EG only things that won't show up in non-eg anyways.

You'd think that, but this had been added, and it looks like this on non-EG clients:
image

It also looks almost as equally terrible on the normal build.

And yes, there is broken LOCR for the subtype "evergreen" on the suits, that part I was fine with.

@grappigegovert
Copy link
Member

Ah interesting. Yeah, I didn't think it would do that, that's quite unfortunate

@RDIL RDIL added authentication Related to the authentication process. evergreen Related to Freelancer mode. labels Nov 21, 2022
@moonysolari
Copy link
Member

moonysolari commented Jan 8, 2023

Have you already fixed / Do you plan to fix #12 with the changes on the Mission End screens on your local branch?

@RDIL RDIL changed the base branch from v5 to v6 January 9, 2023 15:56
@RDIL RDIL marked this pull request as ready for review January 10, 2023 15:40
RDIL and others added 2 commits January 10, 2023 16:40
@AnthonyFuller AnthonyFuller marked this pull request as draft January 28, 2023 17:28
@RDIL RDIL marked this pull request as ready for review January 29, 2023 03:07
@RDIL RDIL marked this pull request as draft January 29, 2023 03:07
@AnthonyFuller AnthonyFuller deleted the evergreen branch January 29, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication Related to the authentication process. evergreen Related to Freelancer mode.
Projects
Development

Successfully merging this pull request may close these issues.

5 participants