Added service for mastery data #30

LennardF1989 · 2022-11-16T22:54:40Z

~~Depends on: #25~~ Added by RDIL, but this is not true. It has portions of which Evergreen can benefit, however.

This PR includes:

A service to handle/retrieve mastery data
Mastery data for all locations, including Evergreen (SNUG).
Added initial support for profile progression on the Player Profile screen as well as when viewing mastery of locations.

This PR does not include:

Actual progression saving/drops on /MissionEnd, even though I already sorted out mastery drops as part of my custom scoring plugin for Evergreen and the storing of that progression per location in the player profile. I will backport that to general purpose later.

General note:

This has been tested on Hitman 3 for Epic, and technically the Steam version though the playtest.
Most likely will work on Hitman 1 and Hitman 2. Otherwise it would be rather easy to exclude this based on game version.

RDIL · 2022-11-16T23:06:44Z

That was unexpected.

AnthonyFuller

All in all a good PR and an especially welcome one! Thanks a lot!

contractdata/AMBROSE/_AMBROSE_MASTERY.json

packaging/buildTasks.mjs

components/candle/masteryService.ts

components/controller.ts

contractdata/CARPATHIAN/_CARPATHIAN_MASTERY.json

packaging/buildTasks.mjs

static/EvergreenMasteryDataForLocationTemplate.json

components/candle/masteryService.ts

LennardF1989 · 2022-11-17T23:00:49Z

Added new commits with the requested changes. Purposely didn't squash so you can easily spot the changes.

While I've fixed a performance issue now that everything is generated runtime, I must add it happens quite often: Every time you go into a Destination. So when you are casually browsing to decide the contract to play, you are constantly doing a lot of calculations to build this object with drops.

If that is acceptable in order to safe some memory, then I'm okay with it.

components/index.ts

AnthonyFuller

This is definitely getting closer to how I envisioned a mastery system. Just a few final things.

contractdata/AMBROSE/_AMBROSE_MASTERY.json

components/contracts/dataGen.ts

components/candle/masteryService.ts

LennardF1989 · 2022-11-18T22:48:30Z

Since all final changes are most likely fully conform agreements, I went ahead and squashed the branch already for a final review.

AnthonyFuller

We're almost there, I can feel it! Just one final thing.

components/candle/masteryService.ts

RDIL · 2022-12-15T16:57:58Z

components/contracts/dataGen.ts

+            "Could not get CompletionData for location ${locationId}",
+        )
+
+        return <CompletionData>{


This cast is still here!

components/candle/masteryService.ts

AnthonyFuller

A few final final things!

AnthonyFuller · 2023-01-19T23:10:32Z

components/contracts/dataGen.ts

+            "Could not get CompletionData for location ${locationId}",
+        )
+
+        return <CompletionData>{


This cast is still here!

contractdata/SNUG/_SNUG_MASTERY.json

components/contracts/dataGen.ts

Added simplified mastery data for all locations Added runtime generation of the full mastery data Added initial support for profile progression Reworked code around loading of resources to be more generic

Fixed typo in the MasteryDataTemplate Removed unnecessary casts Removed unused controller reference

AnthonyFuller

LGTM. Thank you so much for implementing this!

AnthonyFuller self-requested a review November 16, 2022 22:56

LennardF1989 force-pushed the mastery branch from 9f7a5a0 to a860d93 Compare November 16, 2022 22:56

RDIL self-requested a review November 16, 2022 22:57

RDIL added progression Related to the gaining of mastery and other in-game progress. major This will need to be in a semver-major release. labels Nov 16, 2022

AnthonyFuller requested changes Nov 16, 2022

View reviewed changes

RDIL requested changes Nov 16, 2022

View reviewed changes

contractdata/CARPATHIAN/_CARPATHIAN_MASTERY.json Outdated Show resolved Hide resolved

packaging/buildTasks.mjs Outdated Show resolved Hide resolved

static/EvergreenMasteryDataForLocationTemplate.json Outdated Show resolved Hide resolved

RDIL requested changes Nov 16, 2022

View reviewed changes

components/candle/masteryService.ts Outdated Show resolved Hide resolved

RDIL added this to the v6 milestone Nov 17, 2022

alex73630 force-pushed the v5 branch from ee817e8 to baf3c41 Compare November 17, 2022 20:39

LennardF1989 force-pushed the mastery branch 2 times, most recently from d53f5a7 to 46d04b4 Compare November 17, 2022 22:38

LennardF1989 commented Nov 17, 2022

View reviewed changes

components/index.ts Outdated Show resolved Hide resolved

AnthonyFuller requested changes Nov 18, 2022

View reviewed changes

contractdata/AMBROSE/_AMBROSE_MASTERY.json Outdated Show resolved Hide resolved

components/contracts/dataGen.ts Show resolved Hide resolved

components/candle/masteryService.ts Outdated Show resolved Hide resolved

LennardF1989 force-pushed the mastery branch from 6887088 to 7ae11e0 Compare November 18, 2022 22:45

AnthonyFuller requested changes Nov 19, 2022

View reviewed changes

components/candle/masteryService.ts Outdated Show resolved Hide resolved

LennardF1989 force-pushed the mastery branch from f8efed1 to 3e0b1ba Compare November 23, 2022 15:27

RDIL force-pushed the v5 branch from 0077532 to 73ff78b Compare December 13, 2022 03:32

RDIL reviewed Dec 15, 2022

View reviewed changes

RDIL changed the base branch from v5 to v6 January 17, 2023 21:46

LennardF1989 force-pushed the mastery branch from 649270e to e2a0e12 Compare January 19, 2023 19:47

AnthonyFuller requested changes Jan 19, 2023

View reviewed changes

LennardF1989 and others added 4 commits January 20, 2023 21:09

Added service for mastery data

6e4e1ff

Added simplified mastery data for all locations Added runtime generation of the full mastery data Added initial support for profile progression Reworked code around loading of resources to be more generic

Changed MaxLevel to default to 20 instead

84ce99d

Fixed typo in the MasteryDataTemplate Removed unnecessary casts Removed unused controller reference

Fixed a bug when determining the location ID

5b5a50b

Removed remnants of Evergreen

e8842ab

LennardF1989 force-pushed the mastery branch from 718a3ca to e8842ab Compare January 20, 2023 20:09

LennardF1989 requested a review from AnthonyFuller January 20, 2023 20:10

AnthonyFuller approved these changes Jan 20, 2023

View reviewed changes

AnthonyFuller requested a review from RDIL January 20, 2023 20:26

RDIL approved these changes Jan 20, 2023

View reviewed changes

LennardF1989 merged commit 85a55d4 into thepeacockproject:v6 Jan 20, 2023

LennardF1989 deleted the mastery branch January 20, 2023 21:04

moonysolari mentioned this pull request Jan 21, 2023

Fix completion data generation function #85

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added service for mastery data #30

Added service for mastery data #30

LennardF1989 commented Nov 16, 2022 •

edited

Loading

RDIL commented Nov 16, 2022

AnthonyFuller left a comment

LennardF1989 commented Nov 17, 2022

AnthonyFuller left a comment

LennardF1989 commented Nov 18, 2022 •

edited

Loading

AnthonyFuller left a comment

RDIL Dec 15, 2022

AnthonyFuller Jan 19, 2023

AnthonyFuller left a comment

AnthonyFuller Jan 19, 2023

AnthonyFuller left a comment

Added service for mastery data #30

Added service for mastery data #30

Conversation

LennardF1989 commented Nov 16, 2022 • edited Loading

RDIL commented Nov 16, 2022

AnthonyFuller left a comment

Choose a reason for hiding this comment

LennardF1989 commented Nov 17, 2022

AnthonyFuller left a comment

Choose a reason for hiding this comment

LennardF1989 commented Nov 18, 2022 • edited Loading

AnthonyFuller left a comment

Choose a reason for hiding this comment

RDIL Dec 15, 2022

Choose a reason for hiding this comment

AnthonyFuller Jan 19, 2023

Choose a reason for hiding this comment

AnthonyFuller left a comment

Choose a reason for hiding this comment

AnthonyFuller Jan 19, 2023

Choose a reason for hiding this comment

AnthonyFuller left a comment

Choose a reason for hiding this comment

LennardF1989 commented Nov 16, 2022 •

edited

Loading

LennardF1989 commented Nov 18, 2022 •

edited

Loading