Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We're assembling withdrawal transaction even if user chooses to Cancel #603

Closed
michalinacienciala opened this issue Jul 12, 2024 · 11 comments · Fixed by #670
Closed

We're assembling withdrawal transaction even if user chooses to Cancel #603

michalinacienciala opened this issue Jul 12, 2024 · 11 comments · Fixed by #670
Assignees
Labels
🐛 Bug Something isn't working 🎨 dApp dApp

Comments

@michalinacienciala
Copy link
Contributor

michalinacienciala commented Jul 12, 2024

Steps:

  1. Go to withdrawal form and request withdrawal
  2. Press 'Cancel' on a Building transaction data... screen
  3. Wait

Although you cancelled, dapp is still assembling the transaction in the background:

Screen.Recording.2024-07-12.at.14.19.37.mov

After ~1-2 min you'll see the transaction to sign:

Screen.Recording.2024-07-12.at.14.20.04.mov
@kpyszkowski
Copy link
Contributor

There are conceptual limitations to cancel the withdrawal related with tBTC SDK. It's currently impossible to resolve the issue.
@r-czajkowski, please elaborate on the issue to give some more context.

@michalinacienciala
Copy link
Contributor Author

We could get rid of the problem by removing the Cancel and X buttons. I've started a discussion about the issue here: https://www.figma.com/design/j2MModNsoiOYNuBBXbWiM8?node-id=13964-6053#875633552.

@SorinQ
Copy link
Collaborator

SorinQ commented Jul 16, 2024

We could get rid of the problem by removing the Cancel and X buttons. I've started a discussion about the issue here: https://www.figma.com/design/j2MModNsoiOYNuBBXbWiM8?node-id=13964-6053#875633552.

What happens if user kills the session (ex. close the browser tab)?
What happens when he returns?

@SorinQ
Copy link
Collaborator

SorinQ commented Jul 16, 2024

@kpyszkowski Can we make this screen more like a progress bar if we want to? Like 0 to 100%? Hypothetically speaking.

@michalinacienciala
Copy link
Contributor Author

We could get rid of the problem by removing the Cancel and X buttons. I've started a discussion about the issue here: https://www.figma.com/design/j2MModNsoiOYNuBBXbWiM8?node-id=13964-6053#875633552.

What happens if user kills the session (ex. close the browser tab)? What happens when he returns?

If user kills the session during the transaction assembly and logs in again, then there's no assembly still going on in the background, user will not see the transaction to sign (unless they request to withdraw again)

@SorinQ
Copy link
Collaborator

SorinQ commented Jul 16, 2024

That sounds like the correct behavior for cancel :)
Can't we just fake this when the user press cancel? Apologize if my question is silly.

@kpyszkowski
Copy link
Contributor

@SorinQ

Can we make this screen more like a progress bar if we want to? Like 0 to 100%? Hypothetically speaking.

Technically impossible. It really varies - can take few minutes or even an hour. We don't have any progress to present.

Can't we just fake this when the user press cancel?

Also we are technically limited to cancel the process so looks like we are stuck. We cannot "fake" the close of the session.

My idea is to present the message the process cannot be stopped while started. And inform not to close the session to prevent the process from being "lost". Not the best UX but the only solution in my point of view.

@SorinQ
Copy link
Collaborator

SorinQ commented Jul 16, 2024

@kpyszkowski How much time it will take us to build a solution that will allow us to have a functional Cancel button? Again, hypothetically speaking.

@kpyszkowski
Copy link
Contributor

@SorinQ

How much time it will take us to build a solution that will allow us to have a functional Cancel button? Again, hypothetically speaking.

Quite a long time. We rely on tBTC SDK and its needed to "rethink" all underlying processes to allow for redemption cancellation. I think @lukasz-zimnoch and @r-czajkowski can give more details on it.
Let's move the discussion to Discord thread.

@michalinacienciala
Copy link
Contributor Author

Let's move the discussion to Discord thread.

@kpyszkowski was the discussion moved to Discord? If so, can you share the link to he thread?

@michalinacienciala
Copy link
Contributor Author

FYI, this is related to #592 - when user requests withdrawal and dapp is assembling the transaction to sign and then user disconnects the dapp from the wallet, we log the user out, but the assembly is still going on. I don't think this can be as easily fixed as the case with the description of #603.

Screen.Recording.2024-07-18.at.12.12.37.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 🎨 dApp dApp
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants