-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We're assembling withdrawal transaction even if user chooses to Cancel #603
Comments
There are conceptual limitations to cancel the withdrawal related with tBTC SDK. It's currently impossible to resolve the issue. |
We could get rid of the problem by removing the |
What happens if user kills the session (ex. close the browser tab)? |
@kpyszkowski Can we make this screen more like a progress bar if we want to? Like 0 to 100%? Hypothetically speaking. |
If user kills the session during the transaction assembly and logs in again, then there's no assembly still going on in the background, user will not see the transaction to sign (unless they request to withdraw again) |
That sounds like the correct behavior for cancel :) |
Technically impossible. It really varies - can take few minutes or even an hour. We don't have any progress to present.
Also we are technically limited to cancel the process so looks like we are stuck. We cannot "fake" the close of the session. My idea is to present the message the process cannot be stopped while started. And inform not to close the session to prevent the process from being "lost". Not the best UX but the only solution in my point of view. |
@kpyszkowski How much time it will take us to build a solution that will allow us to have a functional Cancel button? Again, hypothetically speaking. |
Quite a long time. We rely on tBTC SDK and its needed to "rethink" all underlying processes to allow for redemption cancellation. I think @lukasz-zimnoch and @r-czajkowski can give more details on it. |
@kpyszkowski was the discussion moved to Discord? If so, can you share the link to he thread? |
FYI, this is related to #592 - when user requests withdrawal and dapp is assembling the transaction to sign and then user disconnects the dapp from the wallet, we log the user out, but the assembly is still going on. I don't think this can be as easily fixed as the case with the description of #603. Screen.Recording.2024-07-18.at.12.12.37.mov |
Steps:
Building transaction data...
screenAlthough you cancelled, dapp is still assembling the transaction in the background:
Screen.Recording.2024-07-12.at.14.19.37.mov
After ~1-2 min you'll see the transaction to sign:
Screen.Recording.2024-07-12.at.14.20.04.mov
The text was updated successfully, but these errors were encountered: