-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancel withdrawal #670
Cancel withdrawal #670
Conversation
Cancel the withdrawal transaction when the user closes the withdrawal flow modal.
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open the error modal only if the error is related to a given withdrawal "session".
Thanks for catching this bug! Should be good now see 66edcdd. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left a small suggestion, let me know what you think.
dapp/src/components/TransactionModal/ActiveUnstakingStep/SignMessageModal.tsx
Show resolved
Hide resolved
To be able to cancel the withdrawal flow when a user closes the modal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Closes #863 The transaction sign window appears despite the rejection of the deposit. Let's already use the solution for the [withdrawal](#670) flow. The cancel logic was moved to `useCancelPromise`. https://github.com/user-attachments/assets/76219622-850c-4aeb-b5cb-f2b44aa884e4
Closes: #603
Closes: #592
Cancel the withdrawal transaction when the user closes the withdrawal flow modal.