Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel withdrawal #670

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Cancel withdrawal #670

merged 4 commits into from
Aug 5, 2024

Conversation

r-czajkowski
Copy link
Contributor

@r-czajkowski r-czajkowski commented Jul 26, 2024

Closes: #603
Closes: #592

Cancel the withdrawal transaction when the user closes the withdrawal flow modal.

Cancel the withdrawal transaction when the user closes the withdrawal
flow modal.
Copy link

netlify bot commented Jul 26, 2024

Deploy Preview for acre-dapp ready!

Name Link
🔨 Latest commit 9c92080
🔍 Latest deploy log https://app.netlify.com/sites/acre-dapp/deploys/66b0d0ec057b810008e9a3a6
😎 Deploy Preview https://deploy-preview-670--acre-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 26, 2024

Deploy Preview for acre-dapp-testnet ready!

Name Link
🔨 Latest commit 9c92080
🔍 Latest deploy log https://app.netlify.com/sites/acre-dapp-testnet/deploys/66b0d0ec6c5d3f0007c03ade
😎 Deploy Preview https://deploy-preview-670--acre-dapp-testnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@kkosiorowska kkosiorowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rejected the withdrawal and then wanted to check if withdrawals work properly after this change. The message signing window showed me but also with an error message.

Screenshot 2024-07-26 at 14 02 36

Steps to reproduce:

  1. Try to do a withdrawal.
  2. Cancel a withdrawal.
  3. Try to do a withdrawal.

Open the error modal only if the error is related to a given withdrawal
"session".
@r-czajkowski
Copy link
Contributor Author

I rejected the withdrawal and then wanted to check if withdrawals work properly after this change. The message signing window showed me but also with an error message.

Screenshot 2024-07-26 at 14 02 36

Steps to reproduce:

1. Try to do a withdrawal.

2. Cancel a withdrawal.

3. Try to do a withdrawal.

Thanks for catching this bug! Should be good now see 66edcdd.

kkosiorowska
kkosiorowska previously approved these changes Jul 31, 2024
Copy link
Contributor

@kkosiorowska kkosiorowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a small suggestion, let me know what you think.

To be able to cancel the withdrawal flow when a user closes the modal.
Copy link
Contributor

@kkosiorowska kkosiorowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kkosiorowska kkosiorowska merged commit 576b6f2 into main Aug 5, 2024
28 checks passed
@kkosiorowska kkosiorowska deleted the withdrawal-cancelation branch August 5, 2024 13:26
r-czajkowski added a commit that referenced this pull request Dec 2, 2024
Closes #863

The transaction sign window appears despite the rejection of the
deposit. Let's already use the solution for the
[withdrawal](#670) flow. The cancel
logic was moved to `useCancelPromise`.


https://github.com/user-attachments/assets/76219622-850c-4aeb-b5cb-f2b44aa884e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants