Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add setup.py to fix dependabot #1832

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Re-add setup.py to fix dependabot #1832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
891e1c7
build: Re-add setup.py
Feb 7, 2022
a622276
build: Remove pylintrc from MANIFEST
Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ include LICENSE*

# Development and testing
include *.txt
global-include pylintrc
include tox.ini
graft tests

Expand Down
4 changes: 4 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# This file exists to keep dependabot happy:
# https://github.com/dependabot/dependabot-core/issues/4483
from setuptools import setup
setup()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, does setup() read from setup.cfg?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should, to my knowledge... but I want to still confirm this

Copy link
Member Author

@jku jku Feb 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as far as I can tell this works fine: the wheels dist-info contains the correct METADATA.

(as a sidenote, we may be missing a license variable as metadata contains License: UNKNOWN, will file an issue)