Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pre-commit image version #307

Merged

Conversation

VannTen
Copy link
Member

@VannTen VannTen commented Jul 28, 2022

Doing it in batch with all-repos since thoth-station/core#462
is not resolved yet

Committed via https://github.com/asottile/all-repos

@sesheta sesheta requested review from harshad16 and KPostOffice July 28, 2022 14:08
@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 28, 2022
@sesheta sesheta added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 28, 2022
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
thanks 💯

@harshad16 harshad16 merged commit 342e978 into thoth-station:master Jul 29, 2022
@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2022
@sesheta
Copy link
Member

sesheta commented Jul 29, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harshad16
To complete the pull request process, please assign sesheta after the PR has been reviewed.
You can assign the PR to them by writing /assign @sesheta in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants