[3pt] create a pre-commit-update-manager

[goern]

Is your feature request related to a problem? Please describe.
see AICoE/aicoe-ci#74 for a detailed description

[sesheta]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[goern]

/remove-lifecycle stale

[goern]

/priority backlog

[sesheta]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

[sesheta]

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[VannTen]

Giving some recent failures on pre-commit (also @goern I think you mentionned
automating pre-commit updates ?) I'd like to reopen this.

Also, some possible alternatives :

• pre-commit.ci
• Piggy-backing on all-repos which
  apparently an "autofixer" for pre-commit (it's by the same author)

/reopen
/sig devsecops
/project SIG-DevSecOps

[sesheta]

@VannTen: You must be a member of the thoth-station/kebechet github team to set the project and column.

In response to this:

Giving some recent failures on pre-commit (also @goern I think you mentionned
automating pre-commit updates ?) I'd like to reopen this.

Also, some possible alternatives :

• pre-commit.ci
• Piggy-backing on all-repos which
  apparently an "autofixer" for pre-commit (it's by the same author)

/reopen
/sig devsecops
/project SIG-DevSecOps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sesheta]

@VannTen: Reopened this issue.

In response to this:

Giving some recent failures on pre-commit (also @goern I think you mentionned
automating pre-commit updates ?) I'd like to reopen this.

Also, some possible alternatives :

• pre-commit.ci
• Piggy-backing on all-repos which
  apparently an "autofixer" for pre-commit (it's by the same author)

/reopen
/sig devsecops
/project SIG-DevSecOps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[VannTen]

@harshad16
Could we pull that into the sig-devsecops project board ?

[harshad16]

Could we pull that into the sig-devsecops project board ?
yes surely done 👍

[harshad16]

Acceptance criteria

• Create a new pipelinerun/taskruns to run precommit autoupdate
• Use gh CLI to do github pr auto update.
• Include it into the pull request pipelinerun.

Higher Goal

• Check if this is important for other Users?
• wrap up this in a bot or github workflow.

Additional thought:

• Is the action required for the user or OSG ecosystem?

Actions:

• Run precommit auto update
• update the image .prow.yaml

/triage accepted
/priority important-soon

[VannTen]

Where is the repo were we could create the new pipelines ? Is it https://github.com/AICoE/aicoe-ci ? I think we mentioned it in the call but can't find the confirmation.

[codificat]

Where is the repo were we could create the new pipelines ? Is it https://github.com/AICoE/aicoe-ci ?

Yes, that's the repo - at least for now. We have the https://github.com/thoth-station/helm-charts/ repo where eventually we might migrate the pipelines, but for the time being aicoe-ci is what drives the pipelines

[VannTen]

Yes, that's the repo - at least for now. We have the https://github.com/thoth-station/helm-charts/ repo where eventually we might migrate the pipelines, but for the time being aicoe-ci is what drives the pipelines

The related discussion in thoth-station/prescriptions-refresh-job#52 (comment) makes me wonder if this should be in aicoe-ci or not or handled by prow (which I've yet to grok where we define stuff, apart from .prow.yaml, see #449). If in AICoE/aicoe-ci, I would model it on the pre-commit one[1], but since that one is not used anymore, I'm reconsidering... [1]: https://github.com/AICoE/aicoe-ci/blob/master/tasks/pre-commit-check.yaml

[harshad16]

I thought about this too,
I feel maybe this should be directly added to prow itself.
creating the periodic job, which updates the image and content would suffice the issue.
https://github.com/operate-first/apps/blob/53376b9bc5b1bb6a794a7f7ef9d5577441fe4b6a/prow/overlays/smaug/config.yaml#L447

[VannTen]

Another alternative: instead of directly using the image version in each repo, we use a named tag (not sure if ImageStream works with ProwJob ?). (Optionally we run the new pre-commit version on recently updated repo when changing the tag, but I don't think changing the tag itself will cause that much breakage, that's mostly the hooks)

[VannTen]

Need to check: can we define a default job in prow config and override in in_repo_config (aka .prow.yaml).

[VannTen]

I would block this until we can get tekton pipelines support for prow in operate-first (operate-first/apps#2462), or a definitive decision that we can't have it). That would make way easier and flexible.

Do we want to move this issue elsewhere since it won't be done in kebechet ?