Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to generate thoth configuration during the build process #189

Closed
fridex opened this issue Jun 3, 2021 · 4 comments
Closed
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@fridex
Copy link
Contributor

fridex commented Jun 3, 2021

Is your feature request related to a problem? Please describe.

As per @wseaton request, we could allow the build process to generate .thoth.yaml configuration file during the actual build process. A nice thing about it is that the build process will detect a runtime environment and users do not need to perform supplying the configuration file. As a side feature, users will not need to explicitly provide .thoth.yaml file in cases when they want to have thoth turned off.

@fridex
Copy link
Contributor Author

fridex commented Jun 3, 2021

As a side feature, users will not need to explicitly provide .thoth.yaml file in cases when they want to have thoth turned off.

This could be wrapped to a singe feature flag to disable all the thoth parts at once.

@goern
Copy link
Member

goern commented Jun 10, 2021

/kind feature
/priority important-longterm

@sesheta sesheta added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jun 10, 2021
@fridex
Copy link
Contributor Author

fridex commented Jul 1, 2021

Done in #190

/close

@sesheta sesheta closed this as completed Jul 1, 2021
@sesheta
Copy link
Member

sesheta commented Jul 1, 2021

@fridex: Closing this issue.

In response to this:

Done in #190

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

3 participants