Allow users to generate thoth configuration during the build process #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesheta
added
the
size/XS
|
I will open the flag for disabling all the thoth in a separate PR. |
goern
reviewed
Jun 4, 2021
README.rst
Outdated
| @@ -47,6 +47,7 @@ Configuration options for Thoth's s2i image: | |||
|
|
|||
| * ``THOTH_ADVISE`` - always use the recommended stack by Thoth (even if the lock file is present in the repo) | |||
| * ``THOTH_CONFIG_CHECK`` - verify values stated in the configuration file match the build environment | |||
| * ``THOTH_GENERATE_CONFIG`` - generate configuration file during the build process, overwrites already existing configuration file if present | |||
There was a problem hiding this comment.
this feels more like THOTH_FORCE_GENERATION_OF_CONFIG shall we make the overwrite more explicit to the user?
|
What is the status of this? |
KPostOffice
approved these changes
Jun 30, 2021
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fridex, KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues and Dependencies
Related: #189
This introduces a breaking change