Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2pt] Create a new ServiceAccount for callback sending task with the ability to delete secrets #2557

Closed
Tracked by #1741
KPostOffice opened this issue May 11, 2022 · 3 comments · Fixed by #2607
Closed
Tracked by #1741

[2pt] Create a new ServiceAccount for callback sending task with the ability to delete secrets #2557

KPostOffice opened this issue May 11, 2022 · 3 comments · Fixed by #2607
Assignees
@KPostOffice
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@KPostOffice
Copy link
Member

Is your feature request related to a problem? Please describe.
After callback urls are sent, the created secret needs to be removed.

Describe the solution you'd like
Create a new serviceAccount, role, roleBinding for a new workflow-helpers task which sends results to callback url
@KPostOffice KPostOffice added the kind/feature Categorizes issue or PR as related to a new feature. label May 11, 2022
@sesheta sesheta added the needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. label May 11, 2022
@KPostOffice KPostOffice mentioned this issue May 11, 2022
Closed
5 tasks
@goern
Copy link
Member

goern commented May 16, 2022

/priority important-soon

@sesheta sesheta added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 16, 2022
@KPostOffice KPostOffice changed the title Create a new ServiceAccount for callback sending task with the ability to delete secrets [2pt]Create a new ServiceAccount for callback sending task with the ability to delete secrets May 23, 2022
@KPostOffice KPostOffice changed the title [2pt]Create a new ServiceAccount for callback sending task with the ability to delete secrets [2pt] Create a new ServiceAccount for callback sending task with the ability to delete secrets May 23, 2022
@KPostOffice
Copy link
Member Author

/sig user-experience

@sesheta sesheta added the sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. label May 23, 2022
@harshad16
Copy link
Member

/triage accepted

@sesheta sesheta added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. labels Jun 6, 2022
@KPostOffice KPostOffice mentioned this issue Jul 6, 2022
Merged
1 task
@KPostOffice KPostOffice mentioned this issue Aug 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KPostOffice KPostOffice

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add new role and role binding for adviser KPostOffice/thoth-application
4 participants
@goern @harshad16 @KPostOffice @sesheta