Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add workflow step to run workflow helper to send webhooks #2617

Merged
merged 1 commit into from
Oct 4, 2022
Merged

add workflow step to run workflow helper to send webhooks #2617

merged 1 commit into from
Oct 4, 2022

Conversation

KPostOffice
Copy link
Member

@KPostOffice KPostOffice commented Jul 12, 2022 •
edited
Loading

created a new argo template and added it to the end of the adviser workflow

Related Issues and Dependencies

depends on: #2607
closes: #2558

@sesheta sesheta added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2022
@sesheta sesheta requested review from goern and mayaCostantini July 12, 2022 20:41
@sesheta
Copy link
Member

sesheta commented Jul 12, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@KPostOffice KPostOffice force-pushed the add-send-step2adviser branch from 8f24155 to 6ee804a Compare July 15, 2022 21:47
harshad16
harshad16 reviewed Aug 31, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make this draft as a pr?

adviser/overlays/ocp4-stage/kustomization.yaml Outdated Show resolved Hide resolved
@KPostOffice KPostOffice force-pushed the add-send-step2adviser branch 3 times, most recently from 4f8eb5c to ebc9088 Compare September 8, 2022 20:24
@KPostOffice
Copy link
Member Author

depends on: https://github.com/thoth-station/user-api/pull/1759/files

@KPostOffice
add workflow step to run workflow helper to send webhooks
b676e9d 
created a new argo template and added it to the end of the adviser workflow
@KPostOffice KPostOffice marked this pull request as ready for review September 21, 2022 19:57
@sesheta sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2022
@sesheta sesheta requested a review from harshad16 September 21, 2022 19:57
@KPostOffice
Copy link
Member Author

@harshad16 WDYT?

harshad16
harshad16 reviewed Sep 27, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
just one thought @KPostOffice

core/base/argo-workflows/send-webhooks.yaml Show resolved Hide resolved
@goern goern removed their request for review September 28, 2022 14:26
harshad16
harshad16 approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 👍

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2022
@sesheta
Copy link
Member

sesheta commented Oct 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2022
@sesheta sesheta merged commit ea37078 into thoth-station:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 approved these changes

@mayaCostantini mayaCostantini Awaiting requested review from mayaCostantini

Assignees

@harshad16 harshad16

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2pt] Create workflow for sending callback urls and schedule it at the end of adviser
3 participants
@KPostOffice @sesheta @harshad16