add new role and role binding for adviser #2607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesheta
added
the
size/M
KPostOffice
force-pushed
the
serv_account4workflow_helpers
branch
2 times, most recently
from
b3eb836 to
4dbf50b
Compare
harshad16
requested changes
Jul 8, 2022
KPostOffice
force-pushed
the
serv_account4workflow_helpers
branch
from
4dbf50b to
2801047
Compare
KPostOffice
force-pushed
the
serv_account4workflow_helpers
branch
from
2801047 to
694d212
Compare
|
can you fix the kustomize issue to get this pr in |
add role which will be used for send webhook step of adviser workflows so that secrets created for callback urls can be deleted
KPostOffice
force-pushed
the
serv_account4workflow_helpers
branch
from
694d212 to
cfad29d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add role which will be used for adviser workflows so that secrets created for callback urls can be deleted
Related Issues and Dependencies
closes: #2557
Does this require new deployment ?
AICoE/aicoe-cdand Prodoperate-first/argocd-apps.