-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and improve I18n for application templates #1004
Conversation
I improved the german translation in a similar pr. See #1002. To preserve the existing behaviour for all other locales I reused the existing translation and tackes on the resource token. But surely this is not optimal for many more locales other then german as well. |
tl;dr Updated locales, tests are passing 🎉 I've updated non-default locales now I ended up including most of the locale changes @hanneskaeufler did in #1002. Thanks for that! Saved me a lot of time my editor didn't play nice with the arabic strings :) @hanneskaeufler I didn't include your German translation update (keys: @nickcharlton let me know if there are any changes you want and if I should squash all the commits together as one :) |
@nickcharlton perhaps merging this and then just opening a new PR with just the 2-line German fix? If @hanneskaeufler is unavailable to do it, I can :) Then the I18n fix for German would be as clean as possibly can be. |
Sure go ahead and merge this and I'll update/reopen something similar to #1002. |
@nickcharlton something blocking this? :) Can I do anything to help? |
@buren Just my time to hit the magic button! I'm going to merge this now. Thanks for all of your time on it! @hanneskaeufler if you could go ahead and do the German language fix in a new PR, that'd be wonderful. |
@nickcharlton 🎉 Sweat! Thank you! |
In #1004 the handling of translation strings improved, but bought in a change to the buttons for new resources. This started to pluralise them when they shouldn't be. So you'd have "New Line items", not "New Line item". This reverts that change.
In #1004 the handling of translation strings improved, but bought in a change to the buttons for new resources. This started to pluralise them when they shouldn't be. So you'd have "New Line items", not "New Line item". This reverts that change.
I finally got around replacing/updating #785, which adds better I18n support for administrate.
config/locale/administrate.en.yml
master
display_resource_name
consistently when callingpage.resource_name
in view templatesi18n-tasks add-missing
other updates (formatting etc) are made in the locale filesrspec ./spec/i18n_spec.rb:9 # I18n does not have missing keys
(see TODO)