-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translations for additional strings #785
Conversation
Great, thanks! Could you drop your I'm concerned that us putting English words in the translations for other languages might end up making us forget about those translations. What do you think about leaving them missing for now (whilst we wait to figure out what they should really be)? |
@nickcharlton I'm thinking we split this guy out and into another gem for i18n. I would vote to wait to merge this guy until we get the translations into its own gem. |
Ok, I'll wait 👍 |
Can you |
Hello everyone! 😄 I'd really like to get this gem merged. Is there a way I can help to get it done? - Don't want to go ahead and create a separate PR unless you say so. PS: I can put together a PR with spanish translations once this one is merged. |
I've created #918 with partial duplication. Didn't notice this PR before. What can I do to make this PR ready for merge ASAP? |
@BenMorganIO should I go ahead and rebase this against |
@buren I'm honestly not sure. I would recommend waiting. cc @nickcharlton |
Hi @buren! I'm not planning on doing that in the near future, but we will eventually. I'd recommend you rebase, and then I think we can get this merged. If you'd also drop the "Merge commit", we'll have a tidy history and I can keep all of your commits, too. |
Finally got around updating/replacing this PR with something :) See #1004. |
Thanks! I'm going to close this for now and start looking over #1004. |
This replaces #478. I had to do this since I removed my fork of administrate while that PR has been open and forking it again didn't "reattach" it to my fork.