Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translations for additional strings #785

Closed
wants to merge 9 commits into from
Closed

Add translations for additional strings #785

wants to merge 9 commits into from

Conversation

buren
Copy link
Contributor

@buren buren commented Mar 17, 2017

This replaces #478. I had to do this since I removed my fork of administrate while that PR has been open and forking it again didn't "reattach" it to my fork.

@buren buren changed the title Translations Add translations for additional strings Mar 17, 2017
@nickcharlton
Copy link
Member

Great, thanks!

Could you drop your Merge branch 'master' commit and instead do a full rebase onto master? It adds a bunch of noise I'd like to try and keep out of the history.

I'm concerned that us putting English words in the translations for other languages might end up making us forget about those translations. What do you think about leaving them missing for now (whilst we wait to figure out what they should really be)?

@BenMorganIO
Copy link
Collaborator

@nickcharlton I'm thinking we split this guy out and into another gem for i18n. I would vote to wait to merge this guy until we get the translations into its own gem.

@BenMorganIO BenMorganIO added the i18n translations and language support label Mar 23, 2017
@buren
Copy link
Contributor Author

buren commented Mar 23, 2017

Ok, I'll wait 👍

@BenMorganIO
Copy link
Collaborator

BenMorganIO commented Apr 4, 2017

Can you git rebase this against master? There are updates for locales in master now.

@patriciomacadden
Copy link
Contributor

Hello everyone! 😄

I'd really like to get this gem merged. Is there a way I can help to get it done? - Don't want to go ahead and create a separate PR unless you say so.

PS: I can put together a PR with spanish translations once this one is merged.

@bronislav
Copy link

bronislav commented Jun 27, 2017

I've created #918 with partial duplication. Didn't notice this PR before.

What can I do to make this PR ready for merge ASAP?

@buren
Copy link
Contributor Author

buren commented Jun 28, 2017

@BenMorganIO should I go ahead and rebase this against master or are you guys till aiming for extracting I18n out to its own gem?

@BenMorganIO
Copy link
Collaborator

@buren I'm honestly not sure. I would recommend waiting. cc @nickcharlton

@nickcharlton
Copy link
Member

Hi @buren! I'm not planning on doing that in the near future, but we will eventually.

I'd recommend you rebase, and then I think we can get this merged. If you'd also drop the "Merge commit", we'll have a tidy history and I can keep all of your commits, too.

@buren
Copy link
Contributor Author

buren commented Oct 16, 2017

Finally got around updating/replacing this PR with something :)

See #1004.

🛎 @nickcharlton

@nickcharlton
Copy link
Member

Thanks! I'm going to close this for now and start looking over #1004.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n translations and language support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants