Tweak primary navigation #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename `sidebar` to `navigation`, which is based on its purpose rather than its visual placement. - Use `nav` element. - Remove unnecessary `ul`; the `nav` provides enough semantics to wrap the links in. - Tweak visual design: show a light background on hover, add more whitespace between navigation links and main content.
tysongach
added
the
views-and-styles
jonatack
pushed a commit
to jonatack/administrate
that referenced
this pull request
May 6, 2017
* Tweak primary navigation - Rename `sidebar` to `navigation`, which is based on its purpose rather than its visual placement. - Use `nav` element. - Remove unnecessary `ul`; the `nav` provides enough semantics to wrap the links in. - Tweak visual design: show a light background on hover, add more whitespace between navigation links and main content. * Add whitespace around main content box (thoughtbot#862)
jonatack
added a commit
to jonatack/administrate
that referenced
this pull request
May 6, 2017
* 'master' of https://github.com/thoughtbot/administrate: Tweak primary navigation (thoughtbot#861) Redesign focus outline styles (thoughtbot#863) Localise Dates (thoughtbot#570) Wrap unsupported form field notes in proper divs (thoughtbot#515) Update customizing_dashboards.md (thoughtbot#568) Wrap table cell contents instead of CSS truncation (thoughtbot#482) Remove worker from Procfile (thoughtbot#854) Remove dependency from ActionMailer (thoughtbot#851) Release version 0.6.0. Remove delayed_job_active_record dependency (thoughtbot#845) use the association includes in the has_many resources as well move include work to an association includes improve performance for n+1s
iarie
pushed a commit
to iarie/administrate
that referenced
this pull request
Jun 17, 2017
* Tweak primary navigation - Rename `sidebar` to `navigation`, which is based on its purpose rather than its visual placement. - Use `nav` element. - Remove unnecessary `ul`; the `nav` provides enough semantics to wrap the links in. - Tweak visual design: show a light background on hover, add more whitespace between navigation links and main content. * Add whitespace around main content box (thoughtbot#862)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sidebartonavigation, which is based on its purpose ratherthan its visual placement.
navelement.ul; thenavprovides enough semantics to wrapthe links in.
whitespace between navigation links and main content.
After this PR:
(“Orders” is being hovered)
Before: