Remove delayed_job_active_record dependency #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The delayed_job_active_record gem was added by suspenders automatically during the generation of this gem. The delayed_job_active_record is not currently used. * Remove delayed_job_active_record dependency * Re-generate appraisal gemfiles to exclude delayed_job_active_record * Remove delayed_job binstubs * Remove BackgroundJobs spec support module
|
"Some checks were not successful" |
|
Yessssss one less gem!!! |
|
Thanks! The tests are failing because of a known flakey test, so I'm going to go ahead and merge anyway. |
ianagne
added a commit
to ianagne/administrate
that referenced
this pull request
May 3, 2017
The delayed_job_active_record gem was removed in thoughtbot#845 and the jobs:work rake task is no longer available. Remove the worker setup from the Procfile so rake jobs:work will not be called.
This was referenced May 3, 2017
nickcharlton
pushed a commit
that referenced
this pull request
May 3, 2017
The delayed_job_active_record gem was removed in #845 and the jobs:work rake task is no longer available. Remove the worker setup from the Procfile so rake jobs:work will not be called.
jonatack
pushed a commit
to jonatack/administrate
that referenced
this pull request
May 6, 2017
The delayed_job_active_record gem was added by suspenders automatically during the generation of this gem. The delayed_job_active_record is not currently used. * Remove delayed_job_active_record dependency * Re-generate appraisal gemfiles to exclude delayed_job_active_record * Remove delayed_job binstubs * Remove BackgroundJobs spec support module
jonatack
pushed a commit
to jonatack/administrate
that referenced
this pull request
May 6, 2017
The delayed_job_active_record gem was removed in thoughtbot#845 and the jobs:work rake task is no longer available. Remove the worker setup from the Procfile so rake jobs:work will not be called.
jonatack
added a commit
to jonatack/administrate
that referenced
this pull request
May 6, 2017
* 'master' of https://github.com/thoughtbot/administrate: Tweak primary navigation (thoughtbot#861) Redesign focus outline styles (thoughtbot#863) Localise Dates (thoughtbot#570) Wrap unsupported form field notes in proper divs (thoughtbot#515) Update customizing_dashboards.md (thoughtbot#568) Wrap table cell contents instead of CSS truncation (thoughtbot#482) Remove worker from Procfile (thoughtbot#854) Remove dependency from ActionMailer (thoughtbot#851) Release version 0.6.0. Remove delayed_job_active_record dependency (thoughtbot#845) use the association includes in the has_many resources as well move include work to an association includes improve performance for n+1s
Merged
iarie
pushed a commit
to iarie/administrate
that referenced
this pull request
Jun 17, 2017
The delayed_job_active_record gem was added by suspenders automatically during the generation of this gem. The delayed_job_active_record is not currently used. * Remove delayed_job_active_record dependency * Re-generate appraisal gemfiles to exclude delayed_job_active_record * Remove delayed_job binstubs * Remove BackgroundJobs spec support module
iarie
pushed a commit
to iarie/administrate
that referenced
this pull request
Jun 17, 2017
The delayed_job_active_record gem was removed in thoughtbot#845 and the jobs:work rake task is no longer available. Remove the worker setup from the Procfile so rake jobs:work will not be called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The delayed_job_active_record gem was added by suspenders automatically
during the generation of this gem. The delayed_job_active_record gem is
not currently used.
Of note, delayed_job_active_record does not currently support Rails 5.1. Removing the dependency has the side bonus of moving us closer to supporting Rails 5.1.