Accessibility improvements #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tysongach
added
the
views-and-styles
houndci-bot
reviewed
May 6, 2017
| @@ -23,7 +23,7 @@ p { | |||
|
|
|||
| a { | |||
| color: $action-color; | |||
| text-decoration: none; | |||
| text-decoration-skip: ink; | |||
There was a problem hiding this comment.
Unknown property text-decoration-skip
There was a problem hiding this comment.
Hound should recognize this going forward from 6e88449#diff-b9ee5b6eb41f94a0d74486255de4ad10R128
|
Great! Could I get you to rebase this? |
Merged
Underlines are a standard way of indicating a link. By only using color to indicate links, people with vision impairments, such as color blindness, might not be able to distinguish linked text from non-linked text.
The vertical pipe is read aloud by screen readers. So a page title of `page | Administrate` would be read as "page vertical pipe Administrate." By using a hyphen instead, the screen reader will read as "page, Administrate." Related: #794
ARIA landmark roles provide useful navigation features for assistive technology and helps people understand the content structure.
tysongach
force-pushed
the
tg-accessibility
branch
from
b445299 to
62af02d
Compare
|
@nickcharlton Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
page | Administratewould be read as ”page vertical pipe Administrate.”