Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility improvements #868

Merged
merged 3 commits into from
May 7, 2017
+9 −8
Merged

Accessibility improvements #868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
848e1fe
Add link underlines
tysongach May 6, 2017
0328c2b
Use a hyphen separator in page titles
tysongach May 6, 2017
62af02d
Add ARIA landmark roles
tysongach May 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/assets/stylesheets/administrate/base/_tables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ table {

a {
color: inherit;
text-decoration: none;
}
}

Expand Down
2 changes: 1 addition & 1 deletion app/assets/stylesheets/administrate/base/_typography.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ p {

a {
color: $action-color;
text-decoration: none;
text-decoration-skip: ink;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unknown property text-decoration-skip

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hound should recognize this going forward from 6e88449#diff-b9ee5b6eb41f94a0d74486255de4ad10R128

transition: color $base-duration $base-timing;

&:hover {
Expand Down
2 changes: 1 addition & 1 deletion app/views/administrate/application/_navigation.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ for all resources in the admin dashboard,
as defined by the routes in the `admin/` namespace
%>

<nav class="navigation">
<nav class="navigation" role="navigation">
<% Administrate::Namespace.new(namespace).resources.each do |resource| %>
<%= link_to(
display_resource_name(resource),
Expand Down
2 changes: 1 addition & 1 deletion app/views/administrate/application/_search.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<form class="search">
<form class="search" role="search">
<span class="search__icon">
<%= svg_tag "administrate/search.svg", "search", width: 16, height: 16 %>
</span>
Expand Down
2 changes: 1 addition & 1 deletion app/views/administrate/application/edit.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ It displays a header, and renders the `_form` partial to do the heavy lifting.

<% content_for(:title) { "#{t("administrate.actions.edit")} #{page.page_title}" } %>

<header class="main-content__header">
<header class="main-content__header" role="banner">
<h1 class="main-content__page-title">
<%= content_for(:title) %>
</h1>
Expand Down
2 changes: 1 addition & 1 deletion app/views/administrate/application/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ It renders the `_table` partial to display details about the resources.
<% end %>
<% end %>

<header class="main-content__header">
<header class="main-content__header" role="banner">
<h1 class="main-content__page-title" id="page-title">
<%= content_for(:title) %>
</h1>
Expand Down
2 changes: 1 addition & 1 deletion app/views/administrate/application/new.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ to do the heavy lifting.

<% content_for(:title) { "#{t("administrate.actions.new")} #{page.resource_name.titleize}" } %>

<header class="main-content__header">
<header class="main-content__header" role="banner">
<h1 class="main-content__page-title">
<%= content_for(:title) %>
</h1>
Expand Down
2 changes: 1 addition & 1 deletion app/views/administrate/application/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ as well as a link to its edit page.

<% content_for(:title) { "#{t("administrate.actions.show")} #{page.page_title}" } %>

<header class="main-content__header">
<header class="main-content__header" role="banner">
<h1 class="main-content__page-title">
<%= content_for(:title) %>
</h1>
Expand Down
2 changes: 1 addition & 1 deletion app/views/layouts/administrate/application.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ By default, it renders:
<meta name="ROBOTS" content="NOODP">
<meta name="viewport" content="initial-scale=1">
<title>
<%= content_for(:title) %> | <%= Rails.application.class.parent_name.titlecase %>
<%= content_for(:title) %> - <%= Rails.application.class.parent_name.titlecase %>
</title>
<%= render "stylesheet" %>
<%= csrf_meta_tags %>
Expand Down