Fix build #872
Merged
Fix build #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems more resilient since it makes sure that the testapp's migrations work.
Follow-up to removal of delayed_job by not relying on it in tests. I just replaced the old namespaced model delayed_job was providing with a custom one.
|
Oh, yes! This is wonderful. Merging away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes spec/generators/dashboard_generator_spec.rb failing randomly? #846. We need to reset model column information in the
Usermodel after creating the newuserstable, so that model schema cache is properly refreshed.Unblocks Abstract model classes should be skipped without warning. #857. There was some leftovers of delayed_job from Remove delayed_job_active_record dependency #845 that were being used to check that namespaced models are not yet supported. I removed them and replaced them with a custom namespaced model to fix the failures Abstract model classes should be skipped without warning. #857 is running into. The new model is the same as in Add support for namespaced models #871, so this should make that PR simpler.
Improves other tiny things in the test setup.