Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle navigation to non-instances #1076

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Handle navigation to non-instances #1076

merged 1 commit into from
Jan 22, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Jan 22, 2024 •
edited
Loading

Pull Request Description

This PR adds error handling for navigating to non-Lemmy instance (such as federated from a different platform), similar to #997.

Review without whitespace.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_HBqwKRJrEA.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

hjiangsu
hjiangsu approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 80f5eb1 into thunder-app:develop Jan 22, 2024
1 check passed
@micahmo micahmo deleted the fix/handle-instance-nav branch January 22, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micahmo @hjiangsu