Fix issue tapping on some usernames #997
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR fixes an issue where we couldn't navigate to some user pages because they were federated users from different platforms. For example, there is
@[email protected]
which is a valid Lemmy user, butmstdn.social
is not a Lemmy instance.Previously we would check if the instance name was a valid Lemmy instance, so I removed that check. Note that this is still safe (in case we encounter an invalid user) because we already had a
try
/catch
aroundnavigateToUserPage
. If it fails, we will still fall back to classic web navigation.Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
qemu-system-x86_64_aKCI14NBZf.mp4
Checklist
semanticLabel
s where applicable for accessibility?