Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue tapping on some usernames #997

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Dec 19, 2023

Pull Request Description

This PR fixes an issue where we couldn't navigate to some user pages because they were federated users from different platforms. For example, there is @[email protected] which is a valid Lemmy user, but mstdn.social is not a Lemmy instance.

Previously we would check if the instance name was a valid Lemmy instance, so I removed that check. Note that this is still safe (in case we encounter an invalid user) because we already had a try/catch around navigateToUserPage. If it fails, we will still fall back to classic web navigation.

This also speeds up the check, because isLemmyInstance would often attempt to make an API call to the instance.

It's unclear whether we should also remove this check from getLemmyCommunity, since I'm unsure whether communities can be federated from non-Lemmy instances.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_aKCI14NBZf.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit e312a4b into thunder-app:develop Dec 19, 2023
@micahmo micahmo deleted the fix/user-tap branch December 19, 2023 18:59
@micahmo micahmo mentioned this pull request Jan 22, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants