Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrectly triggered end of feed when too many filters are applied #1596

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This PR fixes an issue where the feed stops fetching for new posts when there are too many filtered/deleted posts which cause the total number of fetched posts to be zero. Instead of determine the end of the feed from the filtered posts, it now uses the original response's length to determine the end of the feed.

Issue Being Fixed

Issue Number: #1592

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu hjiangsu merged commit e509f05 into develop Nov 18, 2024
1 check passed
@hjiangsu hjiangsu deleted the fix/post-reached-end branch November 18, 2024 15:26
@micahmo
Copy link
Member

micahmo commented Nov 26, 2024

@hjiangsu I'm not sure if it's related to this change, but I've started noticing that my feed always displays "No more items to load" at the end (instead of a spinner) before it proceeds to load more items. Here's a recording.

scrcpy_HJbJoWYrlA.mp4

@micahmo micahmo mentioned this pull request Dec 5, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants