Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrectly triggered end of feed when too many filters are applied #1596

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Fix incorrectly triggered end of feed when too many filters are applied #1596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/feed/utils/post.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ Future<Map<String, dynamic>> fetchFeedItems({
showHidden: showHidden,
));

// Keep the length of the original response to see if there are any additional posts to fetch
int postResponseLength = getPostsResponse.posts.length;

// Remove deleted posts
getPostsResponse = getPostsResponse.copyWith(posts: getPostsResponse.posts.where((PostView postView) => postView.post.deleted == false).toList());

Expand All @@ -69,7 +72,7 @@ Future<Map<String, dynamic>> fetchFeedItems({
List<PostViewMedia> formattedPosts = await parsePostViews(getPostsResponse.posts);
postViewMedias.addAll(formattedPosts);

if (getPostsResponse.posts.isEmpty) hasReachedPostsEnd = true;
if (postResponseLength < limit) hasReachedPostsEnd = true;
currentPage++;
} while (!hasReachedPostsEnd && postViewMedias.length < limit);
}
Expand Down
Loading