Added dimension information to thumbnails to reduce layout jank when using full screen images option #712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
When there is a thumbnail image from the API, retrieve the image's width and height dimensions. This reduces a lot (but not all) layout jank that occurs when scrolling through the feed.
To compare the differences, run the latest release build of Thunder and turn on "View Full Height Images" option in the settings. Go back to feed, refresh if needed, and scroll through the feed (both up and down the feed)
With the latest version, you should be seeing a lot of layout jank. Using this fix should drastically reduce that layout jank. This is only tested on iOS, so some tests should be done on Android as well!
Please note that this is only really visible when you are using a release build, not debug builds.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Unable to upload screen recording on device :(
Checklist
semanticLabel
s where applicable for accessibility?