Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dimension information to thumbnails to reduce layout jank when using full screen images option #712

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Sep 6, 2023

Pull Request Description

When there is a thumbnail image from the API, retrieve the image's width and height dimensions. This reduces a lot (but not all) layout jank that occurs when scrolling through the feed.

To compare the differences, run the latest release build of Thunder and turn on "View Full Height Images" option in the settings. Go back to feed, refresh if needed, and scroll through the feed (both up and down the feed)

With the latest version, you should be seeing a lot of layout jank. Using this fix should drastically reduce that layout jank. This is only tested on iOS, so some tests should be done on Android as well!

Please note that this is only really visible when you are using a release build, not debug builds.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Unable to upload screen recording on device :(

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And seems to work well on Android.

@hjiangsu hjiangsu merged commit ba71808 into develop Sep 7, 2023
@hjiangsu hjiangsu deleted the fix/thumbnail-dimensions-jank branch September 7, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants