Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dimension information to thumbnails to reduce layout jank when using full screen images option #712

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Added dimension information to thumbnails to reduce layout jank when using full screen images option #712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/utils/post.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,15 @@ Future<PostViewMedia> parsePostView(PostView postView, bool fetchImageDimensions
} else if (url != null) {
if (fetchImageDimensions) {
if (postView.post.thumbnailUrl?.isNotEmpty == true) {
media.add(Media(mediaUrl: postView.post.thumbnailUrl!, mediaType: MediaType.link, originalUrl: url));
Size result = await retrieveImageDimensions(postView.post.thumbnailUrl!);
Size size = MediaExtension.getScaledMediaSize(width: result.width, height: result.height, offset: edgeToEdgeImages ? 0 : 24, tabletMode: tabletMode);
media.add(Media(
mediaUrl: postView.post.thumbnailUrl!,
mediaType: MediaType.link,
originalUrl: url,
width: size.width,
height: size.height,
));
} else {
// For external links, attempt to fetch any media associated with it (image, title)
LinkInfo linkInfo = await getLinkInfo(url);
Expand Down