upgrade golang.org/x/net package to fix CVE-2024-45338 #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My investigation indicates that neither our code, nor our dependencies use the functions in question, but at the same time, the impact of upgrading them is minimal, so it feels like the less risky path to just upgrade and not have to worry. Intentionally not bumping go-common at this time. The version of go-common used by shoreline is so old that it does not have the vulnerability, and upgrading it would require additional shoreline modifications. BACK-3351
My investigation indicates that neither our code, nor our dependencies use the functions in question, but at the same time, the impact of upgrading them is minimal, so it feels like the less risky path to just upgrade and not have to worry. This seems to be related to the issue that caused CVE-2024-45338, and I think the fix is ultimately the same, but snyk insists that the old version of golang-jwt/jwt is susceptible, despite us having upgraded to x/net/html package previously. Perhaps they cut and pasted some code or something. Either way, let's fix it up. BACK-3351
ewollesen
force-pushed
the
eric-back-3351
branch
from
2d5a14d to
463bc23
Compare
|
The snyk vulnerability has no remediation at present (awaiting a release from upstream), so we'll have to bypass that for now. |
The latest version isn't compatible with go 1.22. Plus, pinning versions is a good thing so interruptions like this one in the build process don't happen.
ewollesen
commented
Jan 31, 2025
| @@ -5,7 +5,7 @@ RUN adduser -D tidepool && \ | |||
| apk add --no-cache git gcc musl-dev && \ | |||
| chown -R tidepool /go/src/github.com/tidepool-org/shoreline | |||
| USER tidepool | |||
| RUN go install github.com/cosmtrek/air@latest | |||
| RUN go install github.com/air-verse/air@v1.52.2 | |||
There was a problem hiding this comment.
this is the version used in hydrophone
jh-bate
approved these changes
Feb 4, 2025
| @@ -28,8 +28,8 @@ before_install: | |||
| addons: | |||
| apt: | |||
| sources: | |||
| - sourceline: 'deb https://repo.mongodb.org/apt/ubuntu jammy/mongodb-org/7.0 multiverse' | |||
| key_url: 'https://pgp.mongodb.com/server-7.0.asc' | |||
| - sourceline: 'deb https://repo.mongodb.org/apt/ubuntu jammy/mongodb-org/6.0 multiverse' | |||
There was a problem hiding this comment.
I assume this is for consistency with other services?
There was a problem hiding this comment.
Yes.
My understanding is, that even though we were using the 7.0 repo previously, we were using 6.x releases of MongoDB, which matches current prod. At some point the 6.x releases of MongoDB stopped being packaged in the 7.0 repo (I don't know why they ever were), and so we've had to make this adjustment. This isn't the first package to see this change, we're just updating them as we find them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My investigation indicates that neither our code, nor our dependencies
use the functions in question, but at the same time, the impact of
upgrading them is minimal, so it feels like the less risky path to
just upgrade and not have to worry.
Intentionally not bumping go-common at this time. The version of
go-common used by shoreline is so old that it does not have the
vulnerability, and upgrading it would require additional shoreline
modifications.
BACK-3351