-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move responsibility to compute dots and by to method #6559
Conversation
@krlmlr do you still need this one? Right now We can definitely fix the bad default arg either way, of course |
Good catch, I've added comments to the code to explain the reasoning behind the separation. |
@krlmlr would you please take a look at the CI? |
Actually I see the problem, I'll take over and manage merging, thanks! |
Thanks for taking over, I pushed too hastily. |
Required for #6526.
Also fixes default argument of internal helper.