Add comments to separate common from backend-specific code #6594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For duckplyr I'm implementing machinery that extracts code from dplyr. This will allow keeping duckplyr development in sync with dplyr. We're basically feature-complete from day one. We now "only" need to provide duckdb implementations verb by verb.
A lot of argument checking and transformation code will be reused too. I wonder if we could keep anchor comments of the form provided in this PR in the dplyr package. My machinery would pick up those comments, so that synchronization can remain idempotent and pick up future changes to dplyr code.
If we can agree on those comments, I would supply further PRs as duckplyr development progresses. Occasionally, refactorings in the spirit of #6563 and #6559 may be helpful too.
CC @hannes.