Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The order of the two events may be swapped by unified sort #192

Closed
zeminzhou opened this issue Aug 3, 2022 · 0 comments · Fixed by #194
Closed

The order of the two events may be swapped by unified sort #192

zeminzhou opened this issue Aug 3, 2022 · 0 comments · Fixed by #194
Labels
type/bug Something isn't working

Comments

@zeminzhou
Copy link
Contributor

Bug Report

1. Describe the bug

unified sort use heap sort which is unstable algorithm.

2. Minimal reproduce step (Required)

  1. start cdc
  2. batch put same key with different values into src tikv
  3. read src tikv and dst tikv
  4. get different values

3. What did you see instead (Required)

  1. get different values

4. What did you expect to see? (Required)

  1. get same values
@zeminzhou zeminzhou added the type/bug Something isn't working label Aug 3, 2022
@zeminzhou zeminzhou mentioned this issue Aug 3, 2022
Merged
pingyu pushed a commit that referenced this issue Aug 4, 2022
@zeminzhou
[fix #192] fix unified sorter (#194)
86810be 
* fix unified sorter

Signed-off-by: zeminzhou <[email protected]>

* delete log

Signed-off-by: zeminzhou <[email protected]>

* fix ut

Signed-off-by: zeminzhou <[email protected]>

* fix comment

Signed-off-by: zeminzhou <[email protected]>

* fix lint

Signed-off-by: zeminzhou <[email protected]>

* fix lint

Signed-off-by: zeminzhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix #192] fix unified sorter zeminzhou/migration
1 participant
@zeminzhou