[fix #192] fix unified sorter #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zeminzhou <[email protected]>
Signed-off-by: zeminzhou <[email protected]>
Signed-off-by: zeminzhou <[email protected]>
pingyu
reviewed
Aug 4, 2022
cdc/cdc/model/kv.go
Outdated
| @@ -87,11 +87,13 @@ type RawKVEntry struct { | |||
| // Additional debug info | |||
| RegionID uint64 `msg:"region_id"` | |||
| KeySpanID uint64 `msg:"keyspan_id"` | |||
| // For sort | |||
There was a problem hiding this comment.
Suggested change
| // For sort | |
| // For providing additional sequence number. | |
| // To keep `RawKVEntries` from the same region in order during unstable sorting of `sorter`. | |
| // The sequence number is generated by auto-increment in `puller` node of `processor.pipeline`. |
| @@ -69,6 +74,8 @@ func ComparePolymorphicEvents(i, j *PolymorphicEvent) bool { | |||
| } else if j.IsResolved() { | |||
| return true | |||
| } | |||
|
|
|||
| return i.Sequence() < j.Sequence() | |||
There was a problem hiding this comment.
Suggest to add unit test for ComparePolymorphicEvents.
Signed-off-by: zeminzhou <[email protected]>
Signed-off-by: zeminzhou <[email protected]>
Signed-off-by: zeminzhou <[email protected]>
|
@haojinming PTAL~ |
haojinming
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zeminzhou [email protected]
What problem does this PR solve?
fix issue #192
Issue Number: close #192
Problem Description: TBD
The unified sort use heap sort which is unstable algorithm, which can swap two equial events.
What is changed and how does it work?
Add new field for RawKV to help sorter.
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods: