schedule: one operator only occupy one limit #3820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tongjian <[email protected]>
Signed-off-by: tongjian <[email protected]> Signed-off-by: buffer <[email protected]>
Signed-off-by: bufferflies <[email protected]>
Signed-off-by: bufferflies <[email protected]>
ti-chi-bot
added
the
release-note
Codecov Report
@@ Coverage Diff @@
## master #3820 +/- ##
==========================================
- Coverage 75.17% 75.14% -0.03%
==========================================
Files 245 245
Lines 24630 24628 -2
==========================================
- Hits 18515 18507 -8
- Misses 4500 4501 +1
- Partials 1615 1620 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: bufferflies <[email protected]>
HunDunDM
reviewed
Jun 30, 2021
HunDunDM
reviewed
Jun 30, 2021
Signed-off-by: bufferflies <[email protected]>
Signed-off-by: bufferflies <[email protected]>
Signed-off-by: bufferflies <[email protected]>
HunDunDM
reviewed
Jun 30, 2021
Signed-off-by: bufferflies <[email protected]>
nolouch
reviewed
Jul 1, 2021
nolouch
added
type/cherry-pick-for-release-5.0
|
/run-cherry-picker |
HunDunDM
added
needs-cherry-pick-release-4.0
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this pull request
Jul 9, 2021
* use O(1) to get WMA Signed-off-by: tongjian <[email protected]> * add sonar file ignore code duplicated Signed-off-by: tongjian <[email protected]> Signed-off-by: buffer <[email protected]> * one operator should occupy one limit Signed-off-by: bufferflies <[email protected]> * remove no need change Signed-off-by: bufferflies <[email protected]> * move scheduler OpKind to operator.go Signed-off-by: bufferflies <[email protected]> * replace opkind to get op producer by using LowBit Signed-off-by: bufferflies <[email protected]> * pass uint test Signed-off-by: bufferflies <[email protected]> * replace chinese link Signed-off-by: bufferflies <[email protected]> * OperatorCount use O(1) Signed-off-by: bufferflies <[email protected]>
|
In response to a cherrypick label: new pull request created: #3856. |
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this pull request
Jul 9, 2021
* use O(1) to get WMA Signed-off-by: tongjian <[email protected]> * add sonar file ignore code duplicated Signed-off-by: tongjian <[email protected]> Signed-off-by: buffer <[email protected]> * one operator should occupy one limit Signed-off-by: bufferflies <[email protected]> * remove no need change Signed-off-by: bufferflies <[email protected]> * move scheduler OpKind to operator.go Signed-off-by: bufferflies <[email protected]> * replace opkind to get op producer by using LowBit Signed-off-by: bufferflies <[email protected]> * pass uint test Signed-off-by: bufferflies <[email protected]> * replace chinese link Signed-off-by: bufferflies <[email protected]> * OperatorCount use O(1) Signed-off-by: bufferflies <[email protected]>
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this pull request
Jul 9, 2021
Signed-off-by: ti-chi-bot <[email protected]>
This was referenced Jul 9, 2021
|
In response to a cherrypick label: new pull request created: #3857. |
|
In response to a cherrypick label: new pull request created: #3858. |
bufferflies
added a commit
to bufferflies/pd
that referenced
this pull request
Jul 9, 2021
* use O(1) to get WMA Signed-off-by: tongjian <[email protected]> * add sonar file ignore code duplicated Signed-off-by: tongjian <[email protected]> Signed-off-by: buffer <[email protected]> * one operator should occupy one limit Signed-off-by: bufferflies <[email protected]> * remove no need change Signed-off-by: bufferflies <[email protected]> * move scheduler OpKind to operator.go Signed-off-by: bufferflies <[email protected]> * replace opkind to get op producer by using LowBit Signed-off-by: bufferflies <[email protected]> * pass uint test Signed-off-by: bufferflies <[email protected]> * replace chinese link Signed-off-by: bufferflies <[email protected]> * OperatorCount use O(1) Signed-off-by: bufferflies <[email protected]>
ti-chi-bot
added a commit
that referenced
this pull request
Jul 15, 2021
* This is an automated cherry-pick of #3820 Signed-off-by: ti-chi-bot <[email protected]> * fix conflicts Signed-off-by: nolouch <[email protected]> * fix test Signed-off-by: nolouch <[email protected]> Co-authored-by: buffer <[email protected]> Co-authored-by: nolouch <[email protected]>
ti-chi-bot
added a commit
that referenced
this pull request
Jul 22, 2021
* schedule: one operator only occupy one limit (#3820) * use O(1) to get WMA Signed-off-by: tongjian <[email protected]> * add sonar file ignore code duplicated Signed-off-by: tongjian <[email protected]> Signed-off-by: buffer <[email protected]> * one operator should occupy one limit Signed-off-by: bufferflies <[email protected]> * remove no need change Signed-off-by: bufferflies <[email protected]> * move scheduler OpKind to operator.go Signed-off-by: bufferflies <[email protected]> * replace opkind to get op producer by using LowBit Signed-off-by: bufferflies <[email protected]> * pass uint test Signed-off-by: bufferflies <[email protected]> * replace chinese link Signed-off-by: bufferflies <[email protected]> * OperatorCount use O(1) Signed-off-by: bufferflies <[email protected]> * fix test Signed-off-by: nolouch <[email protected]> Co-authored-by: buffer <[email protected]> Co-authored-by: nolouch <[email protected]> Co-authored-by: 混沌DM <[email protected]>
ti-chi-bot
added a commit
that referenced
this pull request
Aug 13, 2021
* schedule: one operator only occupy one limit (#3820) * use O(1) to get WMA Signed-off-by: tongjian <[email protected]> * add sonar file ignore code duplicated Signed-off-by: tongjian <[email protected]> Signed-off-by: buffer <[email protected]> * one operator should occupy one limit Signed-off-by: bufferflies <[email protected]> * remove no need change Signed-off-by: bufferflies <[email protected]> * move scheduler OpKind to operator.go Signed-off-by: bufferflies <[email protected]> * replace opkind to get op producer by using LowBit Signed-off-by: bufferflies <[email protected]> * pass uint test Signed-off-by: bufferflies <[email protected]> * replace chinese link Signed-off-by: bufferflies <[email protected]> * OperatorCount use O(1) Signed-off-by: bufferflies <[email protected]> * opAdmin place first Signed-off-by: bufferflies <[email protected]> * pass unit test Signed-off-by: bufferflies <[email protected]> * pass unit test Signed-off-by: bufferflies <[email protected]> * pass unit test Signed-off-by: bufferflies <[email protected]> Co-authored-by: buffer <[email protected]> Co-authored-by: 混沌DM <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tongjian [email protected]
What problem does this PR solve?
fix: #3807
#3778
What is changed and how it works?
operator controller's count will occupy the highest priority OpKind even if the operator has many OpKind.
the relation between limit and scheduler is blow:
red mark need to be changed
Check List
Tests
Code changes
Side effects
Related changes
Release note