scheduler: simplify the limit judgment of hot-region-scheduler (#3834)

[ti-chi-bot]

This is an automated cherry-pick of #3834

Signed-off-by: HunDunDM [email protected]

What problem does this PR solve?

related #3778
changes caused by #3820

What is changed and how it works?

OpLeader and LeaderScheduleLimit are no longer judged in balance-hot-region-scheduler.

Check List

Tests

• Unit test

Code changes

Side effects

Related changes

• Need to cherry-pick to the release branch

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• bufferflies
• lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[HunDunDM]

The pre-PR is #3856

[bufferflies]

lgtm

[codecov]

Codecov Report

Merging #3855 (8f5c9d6) into release-5.0 (f613602) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           release-5.0    #3855      +/-   ##
===============================================
- Coverage        74.85%   74.74%   -0.11%     
===============================================
  Files              245      245              
  Lines            24239    24224      -15     
===============================================
- Hits             18143    18106      -37     
- Misses            4495     4509      +14     
- Partials          1601     1609       +8     

Flag	Coverage Δ
unittests	74.74% <0.00%> (-0.11%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/schedulers/hot_region.go	79.83% <0.00%> (-1.15%)	⬇️
pkg/tempurl/tempurl.go	45.00% <0.00%> (-15.00%)	⬇️
server/tso/global_allocator.go	71.01% <0.00%> (-6.53%)	⬇️
server/region_syncer/client.go	76.69% <0.00%> (-6.02%)	⬇️
server/member/member.go	65.21% <0.00%> (-4.90%)	⬇️
server/tso/local_allocator.go	80.55% <0.00%> (-2.78%)	⬇️
server/election/leadership.go	83.52% <0.00%> (-2.36%)	⬇️
tools/pd-ctl/pdctl/command/operator.go	65.99% <0.00%> (-1.22%)	⬇️
server/tso/tso.go	72.39% <0.00%> (-0.62%)	⬇️
... and 11 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f613602...8f5c9d6. Read the comment docs.

[HunDunDM]

/merge

[ti-chi-bot]

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 8f5c9d6