Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Wikidata ID to WOF records. #375

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Add Wikidata ID to WOF records. #375

merged 1 commit into from
Apr 26, 2019

Conversation

zerebubuth
Copy link
Member

Parse Wikidata concordances for WOF records and store the result in the database. Used as part of tilezen/vector-datasource#858 to export wikidata IDs in the output tiles for WOF neighbourhoods.

Connects to tilezen/vector-datasource#858.

@zerebubuth zerebubuth requested a review from rmarianski April 17, 2019 16:10
@zerebubuth zerebubuth mentioned this pull request Apr 17, 2019
Merged
nvkelso
nvkelso reviewed Apr 17, 2019
View reviewed changes
Copy link
Member

@nvkelso nvkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a nit in the other PR about wikidata > wikidata_id, so you could make that here, too. But not totally necessary.

@zerebubuth zerebubuth merged commit d7b9484 into master Apr 26, 2019
@zerebubuth zerebubuth deleted the zerebubuth/858-wikidata branch April 26, 2019 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvkelso nvkelso nvkelso left review comments

@rmarianski rmarianski rmarianski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zerebubuth @rmarianski @nvkelso