Export wikidata properties #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvkelso
reviewed
Apr 17, 2019
| @@ -33,7 +33,8 @@ CREATE TABLE wof_neighbourhood ( | |||
| inception DATE NOT NULL DEFAULT '0001-01-01', | |||
| cessation DATE NOT NULL DEFAULT '9999-12-31', | |||
| is_visible BOOLEAN NOT NULL DEFAULT true, | |||
| l10n_name HSTORE | |||
| l10n_name HSTORE, | |||
| wikidata TEXT | |||
There was a problem hiding this comment.
Could leave as wikidata here, might make import easier. But the ETL should transform it to wikidata_id on export.
nvkelso
reviewed
Apr 17, 2019
docs/layers.md
Outdated
| @@ -743,6 +743,7 @@ Places with `kind` values of `continent`, `country`, with others added starting | |||
| * `max_zoom`: a suggested maximum zoom beyond which the place should not be visible. Currently neighbourhoods only, from Who's On First. | |||
| * `is_landuse_aoi`: Currently neighbourhoods only, from Who's On First | |||
| * `kind_detail`: the original value of the OSM `place` tag and Natural Earth `featurecla`, see below. | |||
| * `wikidata`: when present, the [Wikidata](https://www.wikidata.org) ID corresponding to this feature. | |||
There was a problem hiding this comment.
Let's export these as wikidata_id so it's clear what that it's a concordance value not a web link.
nvkelso
reviewed
Apr 17, 2019
docs/layers.md
Outdated
| @@ -827,6 +828,7 @@ To resolve inconsistency in data tagging in OpenStreetMap we normalize several o | |||
| * `exit_to`: only for highway exits | |||
| * `ref`: generally only for `aeroway_gate` and `station_entrance` features | |||
| * `religion`: TODO | |||
| * `wikidata`: when present, the [Wikidata](https://www.wikidata.org) ID corresponding to this feature. | |||
nvkelso
reviewed
Apr 17, 2019
docs/layers.md
Outdated
| @@ -2374,6 +2376,7 @@ Tilezen calculates the composite exterior edge for overlapping water polygons an | |||
| * `area`: in square meters (spherical Mercator, no real-world), `polygon` features only | |||
| * `id`: OpenStreetMap feature `osm_id`, when sourced from `openstreetmap.org` | |||
| * `is_tunnel`: for `line` features only (`true` values only) | |||
| * `wikidata`: when present, the [Wikidata](https://www.wikidata.org) ID corresponding to this feature. | |||
nvkelso
reviewed
Apr 17, 2019
| @@ -926,6 +926,29 @@ def test_plaque_node(self): | |||
| 'kind': u'plaque', | |||
| }) | |||
|
|
|||
| def test_memorial_node(self): | |||
| # if a memorial _isn't_ a plaque, then it should stay as a memorial! | |||
There was a problem hiding this comment.
Added #1872 to remind us to put into changelog.
nvkelso
reviewed
Apr 17, 2019
yaml/places.yaml
Outdated
| @@ -23,6 +23,7 @@ global: | |||
| call: | |||
| func: util.true_or_none | |||
| args: [ { col: is_landuse_aoi } ] | |||
| wikidata: {col: wikidata} | |||
There was a problem hiding this comment.
Export as wikidata_id (see above)
nvkelso
reviewed
Apr 17, 2019
yaml/pois.yaml
Outdated
| @@ -20,6 +20,7 @@ global: | |||
| attraction: {col: attraction} | |||
| zoo: {col: zoo} | |||
| exit_to: {col: exit_to} | |||
| wikidata: {col: wikidata} | |||
There was a problem hiding this comment.
Export as wikidata_id (see above)
nvkelso
reviewed
Apr 17, 2019
yaml/water.yaml
Outdated
| @@ -11,6 +11,7 @@ globals: | |||
| label_placement: {col: label_placement} | |||
| boundary: {col: boundary} | |||
| tunnel: {col: tunnel} | |||
| wikidata: {col: wikidata} | |||
There was a problem hiding this comment.
Export as wikidata_id (see above)
nvkelso
approved these changes
Apr 17, 2019
In the past, we've mostly followed the OSM convention when it comes to property names, which in this case would be just plain |
|
Not yet in a dev build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For features in the
water,placesandpoislayers, export Wikidata IDs, where they're available from upstream data (i.e: OSM, NE or WOF).Note: this requires tilezen/tilequeue#375 for the WOF import to work properly, although tests should still pass without it.
Connects to #858.