Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new kinds for full Maki icon library support #1423

Closed
38 of 47 tasks
nvkelso opened this issue Nov 2, 2017 · 3 comments
Closed
38 of 47 tasks

Add new kinds for full Maki icon library support #1423

nvkelso opened this issue Nov 2, 2017 · 3 comments
Assignees
Milestone

Comments

@nvkelso
Copy link
Member

nvkelso commented Nov 2, 2017

Around 47:

@nvkelso nvkelso added this to the v1.6.0 milestone Nov 2, 2017
@zerebubuth
Copy link
Member

entrance - http://wiki.openstreetmap.org/wiki/Key:entrance – would this go into the buildings layer not pois?

I'm not sure it makes sense in POIs, perhaps buildings would be more appropriate.

The entrance seems like something that isn't useful by itself, and we would want to link the entrance to the POI (or POIs) that it is the entrance to? So that it's possible, when highlighting a large department store or station, to see the entrances for the highlighted feature. But by themselves perhaps they'd only be visible at some very high zoom like z19+?

@nvkelso
Copy link
Member Author

nvkelso commented Nov 3, 2017

entrance smells vaguely of #1305 indoor mapping, too. But I think it's generally useful enough like address numbers to include at z19+ in buildings.

@nvkelso
Copy link
Member Author

nvkelso commented Aug 26, 2018

atv and karaoke_box need icons. So do: boatyard, boat_lift, ship_chandler, crane, customs, harbourmaster, mooring, quay, sanitary_dump_station, waterway_fuel

QA followup in:

Ignoring these ones as don't see evidence for them in OSM:

We didn't add landuse=logging, but maybe that's fine? For the natural or intentional reforestation areas may be used in combination with natural=scrub. https://www.openstreetmap.org/way/540143352#map=17/51.35000/7.03483

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants