More kinds for Maki icon library support #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n camp sites, caravan sites and marinas.
nvkelso
reviewed
Jun 22, 2018
| @@ -769,6 +773,16 @@ filters: | |||
| output: | |||
| <<: *output_properties | |||
| kind: level_crossing | |||
| # filter the waterway / boat fuel before generic amenity=fuel, as they appear | |||
nvkelso
approved these changes
Jun 22, 2018
There was a problem hiding this comment.
Overall LGTM.
Oh, you're 1 step ahead of me, nevermind!
But I think some of these won't have names and we should still allow them to export in the pois layer? So add these to the "ponis" list?
- harbourmaster
- mooring
- sanitary_dump_station
- waterway_fuel
- slipway
Maybe others so please sanity check.
nvkelso
reviewed
Jun 22, 2018
yaml/pois.yaml
Outdated
| any: | ||
| - waterway: fuel | ||
| - "seamark:small_craft_facility:category": fuel_station | ||
| min_zoom: { clamp: { min: 0, max: 16, value: { sum: [ { col: zoom }, 2.7 ] } } } |
There was a problem hiding this comment.
should this be min zoom of say 14 instead of 0? Seems less important than general fuel which I don't think is clamped?
There was a problem hiding this comment.
OK. Updated in fd0f922.
zerebubuth
deleted the
zerebubuth/1423-kinds-for-maki-icon-library-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new kinds:
harbourmastermooringsanitary_dump_stationpathwithkind_detail: quayinroadslayer, similar topier.Additional properties:
mooringonpierandquaysanitary_dump_stationonmarina,camp_siteandcaravan_site.Connects to #1423.