Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide early wood & platform #1740

Merged
merged 4 commits into from
Dec 20, 2018
Merged

Conversation

zerebubuth
Copy link
Member

Connects to #1637.

@zerebubuth zerebubuth requested a review from nvkelso December 19, 2018 16:07
Copy link
Member

@nvkelso nvkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good!

But I think there are a few other platform kind inputs that also need this change?

  • filter: {public_transport: platform, tags->rail: 'yes'}
  • filter: {public_transport: platform, tags->light_rail: 'yes'}
  • filter: {public_transport: platform}

@nvkelso
Copy link
Member

nvkelso commented Dec 19, 2018

Updating for other platform kind inputs in bcae083.

Copy link
Member

@nvkelso nvkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated code, updated tests. Tests pass. Done!

@zerebubuth zerebubuth merged commit 97c53f4 into master Dec 20, 2018
@zerebubuth zerebubuth deleted the zerebubuth/1637-hide-early-wood-platform branch December 20, 2018 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants