Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leading vs from version numbers. #7

Merged
merged 1 commit into from
Mar 19, 2022

Conversation

jfly
Copy link
Contributor

@jfly jfly commented Feb 27, 2022

This fixes #5 (and possibly
#6?):

$ asdf latest bats
1.6.0

This fixes timgluz#5 (and possibly
timgluz#6?):

    $ asdf latest bats
    1.6.0
@jfly
Copy link
Contributor Author

jfly commented Mar 16, 2022

Bump. @timgluz, could you take a look? Thanks!

@timgluz
Copy link
Owner

timgluz commented Mar 19, 2022

@jfly Many thanks for contribution; I will give a try and merge it;

@timgluz timgluz self-requested a review March 19, 2022 12:30
Copy link
Owner

@timgluz timgluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! It worked well;

@@ -11,6 +11,10 @@ function sort_versions() {
LC_ALL=C sort -i -t. -k 1,1 -k 2,2n -k 3,3n -k 4,4n -k 5,5n | awk '{print $2}'
}

function remove_leading_vs() {
sed 's/^v\(.*\)/\1/'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked like charm, thanks!

@timgluz timgluz merged commit 299551f into timgluz:main Mar 19, 2022
@jfly
Copy link
Contributor Author

jfly commented Mar 19, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asdf latest bats returns nothing
2 participants