Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "active PRs below limit" check more precise #45

Closed
timokau opened this issue Jul 4, 2020 · 0 comments · Fixed by #79
Closed

Make "active PRs below limit" check more precise #45

timokau opened this issue Jul 4, 2020 · 0 comments · Fixed by #79

Comments

@timokau
Copy link
Owner

timokau commented Jul 4, 2020

It currently uses github's search to filter by dates. It would be better to be more precise, since being assigned one PR one minute before midnight and another one one minute after isn't quite the intention.
timokau added a commit that referenced this issue Jul 14, 2020
@timokau
Use more precise timeframes for reviewer activity
998f1d1 
Date-only precision is pretty unintuitive. You may review a PR at 23:55
and get another request at 00:00. Gets even more confusing with
different time zones. Its much better to use a precise timeframe and
just ask again in 24 hours (or whatever is configured).

Fixes #45.
@timokau timokau mentioned this issue Jul 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cache reviewer unavailability timokau/marvin-mk2
1 participant
@timokau