Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache reviewer unavailability #79

Merged
merged 4 commits into from
Jul 14, 2020
Merged

Cache reviewer unavailability #79

merged 4 commits into from
Jul 14, 2020

Conversation

timokau
Copy link
Owner

@timokau timokau commented Jul 14, 2020

Fixes #45, fixes #71.

timokau added 4 commits July 14, 2020 20:53
This is a bit more natural/succinct and will make caching possible.
Date-only precision is pretty unintuitive. You may review a PR at 23:55
and get another request at 00:00. Gets even more confusing with
different time zones. Its much better to use a precise timeframe and
just ask again in 24 hours (or whatever is configured).

Fixes #45.
Once we have determined that the number of PRs is over the limit, we can
predict when it might fall below the limit again (assuming no further
activity).
@timokau
Copy link
Owner Author

timokau commented Jul 14, 2020

Tested here.

@timokau timokau merged commit cf3cf56 into master Jul 14, 2020
@timokau timokau deleted the cache-reviewers branch July 14, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache reviewer-availability "no"s Make "active PRs below limit" check more precise
1 participant