Check every event for opt-in before routing #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previously added automatic transitions would have happened unconditionally. Moving the check up to the actual routing will hopefully avoid this issue in the future.
timokau
added a commit
to timokau/infra
that referenced
this pull request
Jun 18, 2020
- move usage documentation into its own document (timokau/marvin-mk2#17) - react to commands in reviews (timokau/marvin-mk2#18) - automatically set to `needs_work` on change requests (timokau/marvin-mk2#18) - automatically set `needs_merge` -> `needs_review` on pushes (timokau/marvin-mk2#19) - perform opt-in check as early as possible (timokau/marvin-mk2#20)
|
Tested here: timokau/marvins-playground#21 (review) |
timokau
added a commit
to timokau/infra
that referenced
this pull request
Jun 19, 2020
- move usage documentation into its own document (timokau/marvin-mk2#17) - react to commands in reviews (timokau/marvin-mk2#18) - automatically set to `needs_work` on change requests (timokau/marvin-mk2#18) - automatically set `needs_merge` -> `needs_review` on pushes (timokau/marvin-mk2#19) - perform opt-in check as early as possible (timokau/marvin-mk2#20) - request reviews on needs_merge (timokau/marvin-mk2#20)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previously added automatic transitions would have happened
unconditionally. Moving the check up to the actual routing will
hopefully avoid this issue in the future.
Ref nix-community/infra#30 (comment).