Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smile :) #21

Closed
wants to merge 4 commits into from
Closed

smile :) #21

wants to merge 4 commits into from

Conversation

cole-h
Copy link

@cole-h cole-h commented Jun 17, 2020

Today is a good day.

@timokau
Copy link
Owner

timokau commented Jun 17, 2020

Indeed it is 🙃

/marvin opt-in

@timokau
Copy link
Owner

timokau commented Jun 17, 2020

Oh, you would have to do that. Well, let me cheat.

@cole-h
Copy link
Author

cole-h commented Jun 17, 2020 •
edited
Loading

/marvin opt-in

EDIT: So close!

@timokau timokau added the marvin label Jun 17, 2020
@timokau
Copy link
Owner

timokau commented Jun 17, 2020

Hah, I probably outran it by a millisecond or two.

@timokau
Copy link
Owner

timokau commented Jun 17, 2020

/marvin needs_review

@timokau
Copy link
Owner

timokau commented Jun 17, 2020

I keep mixing that up

/state needs_review

@timokau
Copy link
Owner

timokau commented Jun 17, 2020

/status needs_review
... you'd think I know the commands

@timokau
Copy link
Owner

timokau commented Jun 17, 2020

Oh, it crashed. Good thing I tried it here first.

@timokau
Copy link
Owner

timokau commented Jun 17, 2020

/status needs_review

@timokau
Copy link
Owner

timokau commented Jun 17, 2020

Third time's the charm.
/status needs_review

timokau
timokau requested changes Jun 17, 2020
View reviewed changes
smile Outdated Show resolved Hide resolved
@timokau
Copy link
Owner

timokau commented Jun 17, 2020

Actually ascii art might be fine.
/status needs_review

timokau
timokau requested changes Jun 17, 2020
View reviewed changes
Copy link
Owner

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is it?

timokau
timokau reviewed Jun 17, 2020
View reviewed changes
Copy link
Owner

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I like it.
/status needs_merge

@timokau timokau mentioned this pull request Jun 17, 2020
Merged
@cole-h
Copy link
Author

cole-h commented Jun 17, 2020

I've added an ASCII art smiley. PTAL.

                    *****************
               ******               ******
           ****                           ****
        ****                                 ***
      ***                                       ***
     **           ***               ***           **
   **           *******           *******          ***
  **            *******           *******            **
 **             *******           *******             **
 **               ***               ***               **
**                                                     **
**       *                                     *       **
**      **                                     **      **
 **   ****                                     ****   **
 **      **                                   **      **
  **       ***                             ***       **
   ***       ****                       ****       ***
     **         ******             ******         **
      ***            ***************            ***
        ****                                 ****
           ****                           ****
               ******               ******
                    *****************

(taken from https://www.asciiart.eu/computers/smileys)

@timokau
Copy link
Owner

timokau commented Jun 17, 2020

😆
/status needs_review
That makes me think that pushes should reset needs_merge -> needs_review.

@timokau
Copy link
Owner

timokau commented Jul 2, 2020

/marvin triage

2 similar comments
@timokau
Copy link
Owner

timokau commented Jul 2, 2020

/marvin triage

@timokau
Copy link
Owner

timokau commented Jul 2, 2020

/marvin triage

@marvin-mk2-test marvin-mk2-test bot requested a review from timokau July 2, 2020 22:12
@timokau
Copy link
Owner

timokau commented Jul 2, 2020

Good bot! (Well, awaiting_changes was not intended but assigning reviewers is nice).

@timokau
Copy link
Owner

timokau commented Jul 14, 2020

Testing some changes in determining reviewer availability (timokau/marvin-mk2#71).
/status needs_reviewer

@timokau
Copy link
Owner

timokau commented Jul 14, 2020

/status awaiting_changes

@timokau
Copy link
Owner

timokau commented Jul 14, 2020

/status needs_reviewer

@timokau
Copy link
Owner

timokau commented Jul 14, 2020

/status awaiting_changes

@timokau
Copy link
Owner

timokau commented Jul 14, 2020

/status needs_reviewer

@timokau
Copy link
Owner

timokau commented Jul 14, 2020

That worked surprisingly well on first try. Good bot.
/status awaiting_changes

@timokau timokau mentioned this pull request Jul 14, 2020
Merged
@timokau
Copy link
Owner

timokau commented Jul 14, 2020 •
edited
Loading

Didn't work quote that well after all: timokau/marvin-mk2#80

@cole-h cole-h closed this Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
awaiting_changes marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cole-h @timokau