Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix review rate limiting and review request race condition #80

Merged
merged 2 commits into from
Jul 14, 2020

Conversation

timokau
Copy link
Owner

@timokau timokau commented Jul 14, 2020

GitHub search parameters need to be urlencoded. Otherwise the newly
introduced UTC offsets (+00:00) are interpreted as separate query
parameters, breaking the rate limiting system.

timokau added 2 commits July 14, 2020 22:32
GitHub search parameters need to be urlencoded. Otherwise the newly
introduced UTC offsets (+00:00) are interpreted as separate query
parameters, breaking the rate limiting system.
@timokau timokau merged commit 1490ba6 into master Jul 14, 2020
@timokau timokau deleted the fix-rate-limit-urlencode branch July 14, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant