ENG-8444 splitting main package #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
kqdeng
force-pushed
the
ENG-8444-split-main-package
branch
from
f7009fb to
4a4eece
Compare
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
mmlb
suggested changes
Sep 9, 2020
Makefile
Outdated
| docker-compose up --build server | ||
| test: | ||
| docker-compose up test | ||
| endif |
grpc-server/grpc_server.go
Outdated
| result.WriteRune('\n') | ||
| } | ||
| // exportedHardware transforms hardware that is returned from cacher into what we want to expose to clients | ||
| func ExportHardware(hw []byte) ([]byte, error) { |
There was a problem hiding this comment.
This doesn't seem like it belong here, maybe in hardware-getter renamed hardware?
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
…d exporting Signed-off-by: Kelly Deng <[email protected]>
…equests Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
kqdeng
force-pushed
the
ENG-8444-split-main-package
branch
from
8d27737 to
1e2830c
Compare
Signed-off-by: Kelly Deng <[email protected]>
kqdeng
force-pushed
the
ENG-8444-split-main-package
branch
from
1e2830c to
e2ce18e
Compare
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
kqdeng
force-pushed
the
ENG-8444-split-main-package
branch
from
e2ce18e to
6b04c5b
Compare
…client' Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
Signed-off-by: Kelly Deng <[email protected]>
mmlb
added a commit
that referenced
this pull request
May 17, 2021
## Description Rebase ENG-8444 split main package to grpc-server, http-server, and hardware #34 made by kelly deng Following are changes: - main package is split into three packages: grpc-server, http-server, and hardware. - hardware package includes all hardware related i.e, defining hardware structs, getting and exporting data from tink/cacher.
|
superseded by #60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kelly Deng [email protected]
Description
This PR splits Hegel's main package into smaller packages:
grpcserverandhttpserverfor more modular code.Thanks @mmlb for the base code for the
main.gofile.Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: