-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase ENG-8444 splitting main package #60
Conversation
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 24.40% 31.49% +7.09%
==========================================
Files 5 3 -2
Lines 504 381 -123
==========================================
- Hits 123 120 -3
+ Misses 359 239 -120
Partials 22 22
Continue to review full report at Codecov.
|
c01bb7a
to
a41666d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job!
a41666d
to
7621946
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Raj-Dharwadkar, this is a great job. Thank you for the time, effort, and energy on this.
Agreed. I don't think we'd want a full refactor atm though so I think the end result being the same is good for incremental progress. It would have been better if the PR itself wasn't one huge commit and instead was smaller obviously correct changes. |
07bc4ea
7621946
to
07bc4ea
Compare
PR-34 from kelly deng Signed-off-by: Raj Dharwadkar <[email protected]>
07bc4ea
to
b661098
Compare
Hello. I would like to request the Approver role in the Hegel repo. GitHub Username @jacobweinstock Role Approver Requirements: - approver from 2020-10-01 until 2022-04-01 - reviewer from 2022-04-29 until present Reviews: - tinkerbell#87 - tinkerbell#66 - tinkerbell#65 - tinkerbell#60 Maintainers @chrisdoherty4, @nshalman, @mmlb
Hello. I would like to request the Approver role in the Hegel repo. GitHub Username @jacobweinstock Role Approver Requirements: - approver from 2020-10-01 until 2022-04-01 - reviewer from 2022-04-29 until present Reviews: - #87 - #66 - #65 - #60 Maintainers @chrisdoherty4, @nshalman, @mmlb ## Description ## Why is this needed Fixes: # ## How Has This Been Tested? ## How are existing users impacted? What migration steps/scripts do we need? ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
Rebase ENG-8444 split main package to grpc-server, http-server, and hardware
Description
rebase changes from PR-34 made by kelly deng
Following are changes:
- main package is split into three packages: grpc-server, http-server, and hardware.
- hardware package includes all hardware related i.e, defining hardware structs, getting and exporting data from tink/cacher.
Why is this needed
Fixes: #
How Has This Been Tested?
setup sandbox: build hegel image with these changes and able to provision OS.
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: