Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase ENG-8444 splitting main package #60

Merged
merged 1 commit into from
May 17, 2021

Conversation

Raj-Dharwadkar
Copy link
Contributor

@Raj-Dharwadkar Raj-Dharwadkar commented Apr 27, 2021

Rebase ENG-8444 split main package to grpc-server, http-server, and hardware

Description

rebase changes from PR-34 made by kelly deng
Following are changes:
- main package is split into three packages: grpc-server, http-server, and hardware.
- hardware package includes all hardware related i.e, defining hardware structs, getting and exporting data from tink/cacher.

Why is this needed

Fixes: #

How Has This Been Tested?

setup sandbox: build hegel image with these changes and able to provision OS.

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #60 (b661098) into master (c8a6831) will increase coverage by 7.09%.
The diff coverage is 26.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   24.40%   31.49%   +7.09%     
==========================================
  Files           5        3       -2     
  Lines         504      381     -123     
==========================================
- Hits          123      120       -3     
+ Misses        359      239     -120     
  Partials       22       22              
Impacted Files Coverage Δ
grpc-server/grpc_server.go 11.25% <11.25%> (ø)
http-server/http_handlers.go 43.01% <45.00%> (ø)
http-server/http_server.go 50.98% <50.98%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8a6831...b661098. Read the comment docs.

@Raj-Dharwadkar Raj-Dharwadkar force-pushed the ENG-8444-rebase branch 3 times, most recently from c01bb7a to a41666d Compare May 5, 2021 16:40
@Raj-Dharwadkar Raj-Dharwadkar marked this pull request as ready for review May 5, 2021 16:58
Copy link

@markjacksonfishing markjacksonfishing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job!

@markjacksonfishing markjacksonfishing requested a review from mmlb May 5, 2021 17:54
mmlb
mmlb previously requested changes May 6, 2021
Makefile Outdated Show resolved Hide resolved
cmd/hegel/main.go Show resolved Hide resolved
jacobweinstock
jacobweinstock previously approved these changes May 14, 2021
Copy link
Member

@jacobweinstock jacobweinstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Raj-Dharwadkar, this is a great job. Thank you for the time, effort, and energy on this.

@markjacksonfishing markjacksonfishing requested a review from mmlb May 14, 2021 18:59
@markjacksonfishing markjacksonfishing dismissed mmlb’s stale review May 14, 2021 18:59

Requested changes were handled

@mmlb
Copy link
Contributor

mmlb commented May 14, 2021

look fine. I imagine it's "better" than what we currently have. it's quite a large PR though with lots of changing/moving parts.

Just for the record:

It does feel like we are trading some current complexities/issues for new ones that should have been avoided. Especially since this is not just a quick and easy split of the main package. Things like removing globals, context propagation, graceful shutdowns should have been discussed as some of the design philosophy for this refactor.

Agreed. I don't think we'd want a full refactor atm though so I think the end result being the same is good for incremental progress. It would have been better if the PR itself wasn't one huge commit and instead was smaller obviously correct changes.

PR-34 from kelly deng

Signed-off-by: Raj Dharwadkar <[email protected]>
@mmlb mmlb added the ready-to-merge Signal to Mergify to merge the PR. label May 17, 2021
@mmlb mmlb merged commit 9f5da0a into tinkerbell:master May 17, 2021
@mmlb mmlb mentioned this pull request May 18, 2021
3 tasks
jacobweinstock added a commit to jacobweinstock/hegel that referenced this pull request May 5, 2022
Hello. I would like to request the Approver role in the Hegel repo.

GitHub Username
@jacobweinstock

Role
Approver

Requirements:
- approver from 2020-10-01 until 2022-04-01 
- reviewer from 2022-04-29 until present

Reviews:
- tinkerbell#87
- tinkerbell#66
- tinkerbell#65
- tinkerbell#60

Maintainers
@chrisdoherty4, @nshalman, @mmlb
@jacobweinstock jacobweinstock mentioned this pull request May 5, 2022
3 tasks
mergify bot added a commit that referenced this pull request May 5, 2022
Hello. I would like to request the Approver role in the Hegel repo.

GitHub Username
@jacobweinstock

Role
Approver

Requirements:
- approver from 2020-10-01 until 2022-04-01 
- reviewer from 2022-04-29 until present

Reviews:
- #87
- #66
- #65
- #60

Maintainers
@chrisdoherty4, @nshalman, @mmlb

## Description



## Why is this needed



Fixes: #

## How Has This Been Tested?





## How are existing users impacted? What migration steps/scripts do we need?





## Checklist:

I have:

- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants