add vendor-data EC2 style path (like user-data) #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When "vendordata" is included in the hardware metadata, expose it through the EC2 path structure. Although vendor-data does not appear to be an EC2 exposed path, tools like cloud-init make all of the paths listed in 2009-04-04 available to scripts and cloud-init takes advantage of these paths, including vendor-data. Signed-off-by: Marques Johansson <[email protected]>
|
Reviewer note: I don't believe this has a hard dependency on tinkerbell/tink#579, but it may be worth looking at first. |
|
@displague Vendor data isn't strictly part of the Equinix metadata standard. I'm not totally sure we should add it. Given we're developing the new Hegel metadata standard how would you feel about exposing vendor data in that instead? |
|
Closing, see #62. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When "vendordata" is included in the hardware metadata, expose it
through the EC2 path structure.
Although vendor-data does not appear to be an EC2 exposed path, tools
like cloud-init make all of the paths listed in 2009-04-04 available to
scripts and cloud-init takes advantage of these paths, including
vendor-data.
Why is this needed
Fixes: #62
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: