Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vendordata to metadata #579

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Add Vendordata to metadata #579

merged 2 commits into from
Aug 16, 2022

Conversation

displague
Copy link
Member

Description

Adds a vendordata key to the metadata structure. This will be used by tinkerbell/hegel#62

Why is this needed

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

The addition of a vendordata path will allow for differentiation between "userdata" and "vendordata" as described in https://cloudinit.readthedocs.io/en/latest/topics/vendordata.html

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@displague displague changed the title Vendor data Adds Vendordata to metadata Jan 12, 2022
@displague displague changed the title Adds Vendordata to metadata Add Vendordata to metadata Jan 12, 2022
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #579 (557dc0c) into main (1618650) will increase coverage by 0.09%.
The diff coverage is n/a.

❗ Current head 557dc0c differs from pull request most recent head 5ed656b. Consider uploading reports for the commit 5ed656b to get more accurate results

@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
+ Coverage   44.43%   44.52%   +0.09%     
==========================================
  Files          61       61              
  Lines        3497     3519      +22     
==========================================
+ Hits         1554     1567      +13     
- Misses       1862     1870       +8     
- Partials       81       82       +1     
Impacted Files Coverage Δ
pkg/apis/core/v1alpha1/hardware_types.go 100.00% <ø> (ø)
pkg/controllers/workflow/controller.go 73.68% <0.00%> (-2.51%) ⬇️
server/dbserver_worker_workflow.go 89.92% <0.00%> (-1.44%) ⬇️
server/kubernetes_api_workflow.go 29.00% <0.00%> (-0.23%) ⬇️
pkg/apis/core/v1alpha1/workflow_methods.go 76.27% <0.00%> (+1.27%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jacobweinstock
Copy link
Member

@chrisdoherty4, mind taking a look at this?

@chrisdoherty4
Copy link
Member

This seems OK for the Kube back-end. Do we need anything in the database? Do we need a discussion around continued database support?

@chrisdoherty4
Copy link
Member

I think we're good to merge this!

chrisdoherty4
chrisdoherty4 previously approved these changes Jul 30, 2022
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
@displague
Copy link
Member Author

rebased

@jacobweinstock jacobweinstock added this to the 0.7.0 milestone Aug 16, 2022
@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Aug 16, 2022
@mergify mergify bot merged commit cf88a1f into tinkerbell:main Aug 16, 2022
@displague displague deleted the vendor-data branch August 16, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants