Proposal for supporting trunked port environments #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
chrisdoherty4
previously approved these changes
Sep 8, 2022
mergify bot
added a commit
to tinkerbell/ipxedust
that referenced
this pull request
Sep 8, 2022
## Description This allows creating an interface with a vlan tag based off of DHCP option 43, suboption 116. This will not change the existing behavior. The vlan interface is only created if DHCP option 43.116 is set. This PR is the start of the implementation of [proposal 28](tinkerbell/proposals#60). ## Why is this needed Fixes: # ## How Has This Been Tested? I have manually test this. ## How are existing users impacted? What migration steps/scripts do we need? No impact. ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
displague
reviewed
Sep 8, 2022
Another proposal was merged as 0028, so I moved this one to 0030. Also, added a comment regarding DHCP option 132. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
vlan-support
branch
from
03c8968 to
d6fee9a
Compare
3 tasks
mergify bot
added a commit
to tinkerbell/tink
that referenced
this pull request
Sep 16, 2022
## Description This adds vlan id to interfaces in the hardware spec. FYI, hidden inside of all this generated code, linting, and dependency version updates is the reason for this PR. The small addition of vlan id to the hardware interface struct. Look here: `/pkg/apis/core/v1alpha1/hardware_types.go`. Also, important to note that this PR updates the Go version from `1.17` to `1.18`, this was required to get the make targets for generating code functioning properly for me. ## Why is this needed Needed to enabled trunk port support across the stack. See proposal tinkerbell/proposals#60 Fixes: # ## How Has This Been Tested? ## How are existing users impacted? What migration steps/scripts do we need? ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
3 tasks
mergify bot
added a commit
to tinkerbell/smee
that referenced
this pull request
Sep 23, 2022
## Description This enables Boots to setup DHCP option 43, sub option 116 with the VLAN ID pulled from the hardware record. This also adds a kernel command line parameter to the default (OSIE) installer auto.ipxe script with the vlan id (`vlan_id=`). This will enable Hook to create a tagged vlan interface when it boots up. This is all inline with proposal [0030](tinkerbell/proposals#60). This is only being implemented with the Kubernetes backend. The Tink+Postgresql is [deprecated](https://github.com/tinkerbell/proposals/tree/main/proposals/0029) and the Cacher backend is not officially deprecated (yet) but should be considered legacy. ## Why is this needed Fixes: # ## How Has This Been Tested? Manual testing following the K3D guide [here](https://github.com/tinkerbell/boots/blob/main/docs/manifests/k3d.md). ## How are existing users impacted? What migration steps/scripts do we need? No impacts. ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
Hopefully this will help folks that want to dig into this option 132 a little more. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
requested review from
displague
and removed request for
displague
displague
approved these changes
Oct 11, 2022
jacobweinstock
requested review from
chrisdoherty4
and removed request for
chrisdoherty4
chrisdoherty4
approved these changes
Oct 11, 2022
chrisdoherty4
pushed a commit
to chrisdoherty4/tinkerbell-proposals
that referenced
this pull request
Jan 14, 2023
## Description Add support for trunked port environments. Rendered proposal: https://github.com/jacobweinstock/proposals/blob/vlan-support/proposals/0030/README.md ## Why is this needed Fixes: # ## How Has This Been Tested? ## How are existing users impacted? What migration steps/scripts do we need? ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade ----- [View rendered proposals/0030/README.md](https://github.com/jacobweinstock/proposals/blob/vlan-support/proposals/0030/README.md) Signed-off-by: Chris Doherty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for trunked port environments.
Rendered proposal: https://github.com/jacobweinstock/proposals/blob/vlan-support/proposals/0030/README.md
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have:
View rendered proposals/0030/README.md